Complete support for Windows TLS destructors

runtime/vm/growable_array.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 // Defines growable array classes, that differ where they are allocated:
 // - GrowableArray: allocated on stack.
 // - ZoneGrowableArray: allocated in the zone.
 // - MallocGrowableArray: allocates using malloc/realloc; free is only called
 //   at destruction.
 
 #ifndef VM_GROWABLE_ARRAY_H_
@@ skipping 92 matching lines @@
   void Swap(intptr_t i, intptr_t j) {
     ASSERT(i >= 0);
     ASSERT(j >= 0);
     ASSERT(i < length_);
     ASSERT(j < length_);
     T temp = data_[i];
     data_[i] = data_[j];
     data_[j] = temp;
   }
 
+  // NOTE: Does not preserve array order.
+  void RemoveAt(intptr_t i) {
+    ASSERT(i >= 0);
+    ASSERT(i < length_);
+    if (i < length_ - 1) {

[siva, 2015/10/15 22:42:48]

if (i < (length_ -1)) {

for better readability.

[Cutch, 2015/10/16 16:53:25]

Done.

+      Swap(i, length_ - 1);
+    }
+    RemoveLast();
+  }
+
   // The content is uninitialized after calling it.
   void SetLength(intptr_t new_length);
 
   // Sort the array in place.
   inline void Sort(int compare(const T*, const T*));
 
  private:
   intptr_t length_;
   intptr_t capacity_;
   T* data_;
@@ skipping 154 matching lines @@
  public:
   explicit MallocGrowableArray(intptr_t initial_capacity)
       : BaseGrowableArray<T, EmptyBase, Malloc>(initial_capacity, NULL) {}
   MallocGrowableArray()
       : BaseGrowableArray<T, EmptyBase, Malloc>(NULL) {}
 };
 
 }  // namespace dart
 
 #endif  // VM_GROWABLE_ARRAY_H_