Complete support for Windows TLS destructors

runtime/vm/os_thread_win.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_OS_THREAD_WIN_H_
 #define VM_OS_THREAD_WIN_H_
 
 #if !defined(VM_OS_THREAD_H_)
 #error Do not include os_thread_win.h directly; use os_thread.h instead.
 #endif
@@ skipping 98 matching lines @@
   MonitorWaitData* waiters_tail_;
 
   friend class Monitor;
   friend class OS;
   friend unsigned int __stdcall ThreadEntry(void* data_ptr);
 
   DISALLOW_ALLOCATION();
   DISALLOW_COPY_AND_ASSIGN(MonitorData);
 };
 
+
+typedef void (*ThreadDestructor) (void* parameter);
+
+
+class ThreadLocalEntry {
+ public:
+  ThreadLocalEntry(ThreadLocalKey key, ThreadDestructor destructor)
+      : key_(key),
+        destructor_(destructor) {
+  }
+
+  ThreadLocalKey key() const {
+    return key_;
+  }
+
+
+  ThreadDestructor destructor() const {
+    return destructor_;
+  }
+
+ private:
+  ThreadLocalKey key_;
+  ThreadDestructor destructor_;

[siva, 2015/10/15 22:42:48]

DISALLOW_COPY_AND_ASSIGN(...);
DISALLOW_ALLOCATION(...);

[Cutch, 2015/10/16 16:53:26]

Added DISALLOW_ALLOCATION but not DISALLOW_COPY_AND_ASSIGN because
MallocGrowableArray needs copy and assignment operators.

+};
+
+
+template<typename T>
+class MallocGrowableArray;
+
+
+class ThreadLocalData {

[siva, 2015/10/15 22:42:48]

class ThreadLocalData : public AllStatic {

[Cutch, 2015/10/16 16:53:26]

Done.

+ public:
+  static void AddThreadLocal(ThreadLocalKey key, ThreadDestructor destructor);
+  static void RemoveThreadLocal(ThreadLocalKey key);

[siva, 2015/10/15 22:42:48]

Should we make OSThread a friend class and make all of these also private
methods.

[Cutch, 2015/10/16 16:53:25]

Done.

+
+  static void RunDestructors();
+
+ private:
+  static Mutex* mutex_;
+  static MallocGrowableArray<ThreadLocalEntry>* thread_locals_;
+
+  static void InitOnce();
+  static void Shutdown();
+
+  friend class OS;
+};
+
 }  // namespace dart
 
 #endif  // VM_OS_THREAD_WIN_H_