Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1410223004: Parse animation-name in CSSPropertyParser with CSSParserTokens (Closed)

Created:
5 years, 2 months ago by Timothy Loh
Modified:
5 years, 2 months ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@anim2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Parse animation-name in CSSPropertyParser with CSSParserTokens This patch moves the parsing logic for animation-name out of the LegacyCSSProperty and into the CSSPropertyParser. This property has special behaviour when specified as -webkit-animation-name, so parseSingleValue is updated to take an unresolved properties instead of a resolved property. consumeAnimationValue's arguments are extended so we can continue counting usage of the non-standard behaviour. BUG=499780 Committed: https://crrev.com/271e821edda950d1f54af8bc3d6d8217ddfb0427 Cr-Commit-Position: refs/heads/master@{#354993}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -8 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 7 chunks +30 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 2 chunks +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
rwlbuis
lgtm with one nit. https://codereview.chromium.org/1410223004/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/1410223004/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp#newcode946 third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:946: // Legacy support for strings ...
5 years, 2 months ago (2015-10-19 21:22:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410223004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410223004/20001
5 years, 2 months ago (2015-10-20 05:57:00 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-20 06:00:54 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 06:01:50 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/271e821edda950d1f54af8bc3d6d8217ddfb0427
Cr-Commit-Position: refs/heads/master@{#354993}

Powered by Google App Engine
This is Rietveld 408576698