Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: chrome/browser/extensions/api/messaging/native_process_launcher_win.cc

Issue 1410333006: Enough hacks to make wstring printfs unneeded (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/messaging/native_process_launcher_win.cc
diff --git a/chrome/browser/extensions/api/messaging/native_process_launcher_win.cc b/chrome/browser/extensions/api/messaging/native_process_launcher_win.cc
index fa01111b2e677d2a11f7e41ed5a083d6ed365b32..2f6d859485f7da31c3cdb12781133baf30ea3f3a 100644
--- a/chrome/browser/extensions/api/messaging/native_process_launcher_win.cc
+++ b/chrome/browser/extensions/api/messaging/native_process_launcher_win.cc
@@ -106,10 +106,10 @@ bool NativeProcessLauncher::LaunchNativeProcess(
uint64 pipe_name_token;
crypto::RandBytes(&pipe_name_token, sizeof(pipe_name_token));
- base::string16 out_pipe_name = base::StringPrintf(
- L"\\\\.\\pipe\\chrome.nativeMessaging.out.%llx", pipe_name_token);
- base::string16 in_pipe_name = base::StringPrintf(
- L"\\\\.\\pipe\\chrome.nativeMessaging.in.%llx", pipe_name_token);
+ base::string16 out_pipe_name = L"";/*base::StringPrintf(
+ L"\\\\.\\pipe\\chrome.nativeMessaging.out.%llx", pipe_name_token);*/
+ base::string16 in_pipe_name = L"";/* base::StringPrintf(
+ L"\\\\.\\pipe\\chrome.nativeMessaging.in.%llx", pipe_name_token);*/
// Create the pipes to read and write from.
base::win::ScopedHandle stdout_pipe(
@@ -144,10 +144,10 @@ bool NativeProcessLauncher::LaunchNativeProcess(
base::string16 command_line_string = command_line.GetCommandLineString();
- base::string16 command = base::StringPrintf(
+ base::string16 command = L"";/* base::StringPrintf(
L"%ls /c %ls < %ls > %ls",
comspec.get(), command_line_string.c_str(),
- in_pipe_name.c_str(), out_pipe_name.c_str());
+ in_pipe_name.c_str(), out_pipe_name.c_str());*/
brucedawson 2015/10/20 21:43:00 String printing of %COMSPEC% and GetCommandLineStr
base::LaunchOptions options;
options.start_hidden = true;

Powered by Google App Engine
This is Rietveld 408576698