chrome/browser/extensions/api/proxy/proxy_api.cc - Issue 1410333006: Enough hacks to make wstring printfs unneeded

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/proxy/proxy_api.cc

Issue 1410333006: Enough hacks to make wstring printfs unneeded (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/proxy/proxy_api.cc

diff --git a/chrome/browser/extensions/api/proxy/proxy_api.cc b/chrome/browser/extensions/api/proxy/proxy_api.cc

index 148500709c6d66f79cb8456b008c5b40c223eed6..19fce0021333544b9e2ef8c8a8914c2a2457a92c 100644

--- a/chrome/browser/extensions/api/proxy/proxy_api.cc

+++ b/chrome/browser/extensions/api/proxy/proxy_api.cc

@@ -67,9 +67,9 @@ void ProxyEventRouter::OnPACScriptError(

net::ErrorToString(net::ERR_PAC_SCRIPT_FAILED));

std::string error_msg;

if (line_number != -1) {

- base::SStringPrintf(&error_msg,

+ /*base::SStringPrintf(&error_msg,

"line: %d: %s",

- line_number, base::UTF16ToUTF8(error).c_str());

+ line_number, base::UTF16ToUTF8(error).c_str());*/

brucedawson 2015/10/20 21:43:00 Printing of UTF16ToUTF8 error string - seems very

} else {

error_msg = base::UTF16ToUTF8(error);

}