Enough hacks to make wstring printfs unneeded

chrome/browser/extensions/api/messaging/native_process_launcher_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/messaging/native_process_launcher.h"
 
 #include <windows.h>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 88 matching lines @@
   // CreateNamedPipeW().
   const DWORD kBufferSize = 0;
 
   if (!command_line.GetProgram().IsAbsolute()) {
     LOG(ERROR) << "Native Messaging host path must be absolute.";
     return false;
   }
 
   uint64 pipe_name_token;
   crypto::RandBytes(&pipe_name_token, sizeof(pipe_name_token));
-  base::string16 out_pipe_name = base::StringPrintf(
-      L"\\\\.\\pipe\\chrome.nativeMessaging.out.%llx", pipe_name_token);
-  base::string16 in_pipe_name = base::StringPrintf(
-      L"\\\\.\\pipe\\chrome.nativeMessaging.in.%llx", pipe_name_token);
+  base::string16 out_pipe_name = L"";/*base::StringPrintf(
+      L"\\\\.\\pipe\\chrome.nativeMessaging.out.%llx", pipe_name_token);*/
+  base::string16 in_pipe_name = L"";/* base::StringPrintf(
+      L"\\\\.\\pipe\\chrome.nativeMessaging.in.%llx", pipe_name_token);*/
 
   // Create the pipes to read and write from.
   base::win::ScopedHandle stdout_pipe(
       CreateNamedPipeW(out_pipe_name.c_str(),
                        PIPE_ACCESS_INBOUND | FILE_FLAG_OVERLAPPED |
                            FILE_FLAG_FIRST_PIPE_INSTANCE,
                        PIPE_TYPE_BYTE, 1, kBufferSize, kBufferSize,
                        kTimeoutMs, NULL));
   if (!stdout_pipe.IsValid()) {
     LOG(ERROR) << "Failed to create pipe " << out_pipe_name;
@@ skipping 14 matching lines @@
   DWORD comspec_length = ::GetEnvironmentVariable(L"COMSPEC", NULL, 0);
   if (comspec_length == 0) {
     LOG(ERROR) << "COMSPEC is not set";
     return false;
   }
   scoped_ptr<wchar_t[]> comspec(new wchar_t[comspec_length]);
   ::GetEnvironmentVariable(L"COMSPEC", comspec.get(), comspec_length);
 
   base::string16 command_line_string = command_line.GetCommandLineString();
 
-  base::string16 command = base::StringPrintf(
+  base::string16 command = L"";/* base::StringPrintf(
       L"%ls /c %ls < %ls > %ls",
       comspec.get(), command_line_string.c_str(),
-      in_pipe_name.c_str(), out_pipe_name.c_str());
+      in_pipe_name.c_str(), out_pipe_name.c_str());*/

[brucedawson, 2015/10/20 21:43:00]

String printing of %COMSPEC% and GetCommandLineString()

 
   base::LaunchOptions options;
   options.start_hidden = true;
   base::Process cmd_process = base::LaunchProcess(command.c_str(), options);
   if (!cmd_process.IsValid()) {
     LOG(ERROR) << "Error launching process "
                << command_line.GetProgram().MaybeAsASCII();
     return false;
   }
 
   bool stdout_connected = ConnectNamedPipe(stdout_pipe.Get(), NULL) ?
       TRUE : GetLastError() == ERROR_PIPE_CONNECTED;
   bool stdin_connected = ConnectNamedPipe(stdin_pipe.Get(), NULL) ?
       TRUE : GetLastError() == ERROR_PIPE_CONNECTED;
   if (!stdout_connected || !stdin_connected) {
     cmd_process.Terminate(0, false);
     LOG(ERROR) << "Failed to connect IO pipes when starting "
                << command_line.GetProgram().MaybeAsASCII();
     return false;
   }
 
   *process = cmd_process.Pass();
   *read_file = base::File::CreateForAsyncHandle(stdout_pipe.Take());
   *write_file = base::File::CreateForAsyncHandle(stdin_pipe.Take());
 
   return true;
 }
 
 }  // namespace extensions