Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1410333006: Enough hacks to make wstring printfs unneeded (Closed)

Created:
5 years, 2 months ago by brucedawson
Modified:
4 years, 7 months ago
Reviewers:
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enough hacks to make wstring printfs unneeded Do not check in!!! BUG=533002

Patch Set 1 #

Total comments: 7

Patch Set 2 : Removing unnecessary changes #

Patch Set 3 : Reverting another unneeded change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -95 lines) Patch
M base/memory/shared_memory_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/message_loop/message_pump_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/profiler/native_stack_sampler_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/stringprintf.h View 1 2 chunks +8 lines, -8 lines 0 comments Download
M base/strings/stringprintf.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M base/strings/stringprintf_unittest.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M base/trace_event/memory_allocator_dump.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/win/event_trace_consumer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/win/event_trace_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_target_determiner.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_process_launcher_win.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/first_run/upgrade_util_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/shell_integration_win.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/common/cloud_print/cloud_print_helpers.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/advanced_firewall_manager_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/google_chrome_distribution.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/l10n_string_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/browser_watcher/exit_code_watcher_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_watcher/exit_funnel_win.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/crash/content/app/breakpad_win.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/crash/content/app/crash_keys_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/os_crypt/ie7_password_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/storage_monitor/volume_mount_watcher_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter_win.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M content/browser/download/save_package.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/sandbox_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/embedder/platform_channel_pair_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/win/src/sandbox_policy_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/win/src/sync_policy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/platform_channel_pair_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M win8/delegate_execute/delegate_execute_util_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
brucedawson
5 years, 2 months ago (2015-10-20 21:43:00 UTC) #2 
https://codereview.chromium.org/1410333006/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/messaging/native_process_launcher_win.cc
(right):

https://codereview.chromium.org/1410333006/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/messaging/native_process_launcher_win.cc:150:
in_pipe_name.c_str(), out_pipe_name.c_str());*/
String printing of %COMSPEC% and GetCommandLineString()

https://codereview.chromium.org/1410333006/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/proxy/proxy_api.cc (right):

https://codereview.chromium.org/1410333006/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/proxy/proxy_api.cc:72: line_number,
base::UTF16ToUTF8(error).c_str());*/
Printing of UTF16ToUTF8 error string - seems very odd.

https://codereview.chromium.org/1410333006/diff/1/chrome/browser/profiles/pro...
File chrome/browser/profiles/profile_shortcut_manager_win.cc (right):

https://codereview.chromium.org/1410333006/diff/1/chrome/browser/profiles/pro...
chrome/browser/profiles/profile_shortcut_manager_win.cc:635: return L"";/*
base::StringPrintf(L"--%ls=\"%ls\"",
String printing of ASCIIToUTF16 and profile_path.

https://codereview.chromium.org/1410333006/diff/1/chrome/installer/util/shell...
File chrome/installer/util/shell_util.cc (right):

https://codereview.chromium.org/1410333006/diff/1/chrome/installer/util/shell...
chrome/installer/util/shell_util.cc:1495: //base::StringPrintf(L"unused_program
%ls", args.c_str())));
String printing of arguments.

https://codereview.chromium.org/1410333006/diff/1/content/browser/accessibili...
File content/browser/accessibility/accessibility_tree_formatter_win.cc (right):

https://codereview.chromium.org/1410333006/diff/1/content/browser/accessibili...
content/browser/accessibility/accessibility_tree_formatter_win.cc:311: /*       
WriteAttribute(false,
String printing of UTF8toUTF16(attribute_name), three times.

https://codereview.chromium.org/1410333006/diff/1/content/common/sandbox_win.cc
File content/common/sandbox_win.cc (right):

https://codereview.chromium.org/1410333006/diff/1/content/common/sandbox_win....
content/common/sandbox_win.cc:243: return
/*base::StringPrintf(L"\\Sessions\\%lu%ls", s_session_id, object)*/ L"";
String printing - prepending logon session to object path.

https://codereview.chromium.org/1410333006/diff/1/extensions/browser/guest_vi...
File extensions/browser/guest_view/web_view/web_view_guest.cc (right):

https://codereview.chromium.org/1410333006/diff/1/extensions/browser/guest_vi...
extensions/browser/guest_view/web_view/web_view_guest.cc:1191: error,
webview::kAPILoadDataInvalidDataURL, data_url.c_str());*/
String printing of GURLs (three very similar instances).

Powered by Google App Engine
This is Rietveld 408576698