components/storage_monitor/volume_mount_watcher_win.cc - Issue 1410333006: Enough hacks to make wstring printfs unneeded

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/storage_monitor/volume_mount_watcher_win.cc

Issue 1410333006: Enough hacks to make wstring printfs unneeded (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reverting another unneeded change. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/storage_monitor/volume_mount_watcher_win.cc

diff --git a/components/storage_monitor/volume_mount_watcher_win.cc b/components/storage_monitor/volume_mount_watcher_win.cc

index 168d2eb14dea19b21c28d6fd932dd62955dcce2c..9fbd3a08cba71cf057f90e37a9e4c7a61916249c 100644

--- a/components/storage_monitor/volume_mount_watcher_win.cc

+++ b/components/storage_monitor/volume_mount_watcher_win.cc

@@ -237,7 +237,8 @@ void EjectDeviceInThreadPool(

base::Bind(callback, StorageMonitor::EJECT_FAILURE));

return;

}

- base::SStringPrintf(&volume_name, L"\\\\.\\%lc:", drive_letter);

+ // safe

+ //base::SStringPrintf(&volume_name, L"\\\\.\\%lc:", drive_letter);

base::win::ScopedHandle volume_handle(CreateFile(

volume_name.c_str(),