Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1413543003: Move remaining animation and transition longhands to CSSPropertyParser (Closed)

Created:
5 years, 2 months ago by Timothy Loh
Modified:
5 years, 2 months ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@anim3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move remaining animation and transition longhands to CSSPropertyParser This patch moves parsing for the following properties from the legacy property parser to the new one based around CSSParserTokens: animation-direction animation-fill-mode animation-iteration-count animation-play-state transition-property Since transition-property has a special value of 'none', which is only allowed by itself, I've added a isValidAnimationPropertyList function which checks this. The check for whether we're actually parsing transition-property is inside this function because I think it makes the shorthand code (in a subsequent patch) slightly cleaner. BUG=499780 Committed: https://crrev.com/9cceab3556c26210436911e806f6abd5aff4ee30 Cr-Commit-Position: refs/heads/master@{#355032}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -8 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 6 chunks +79 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 2 chunks +5 lines, -8 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
rwlbuis
lgtm
5 years, 2 months ago (2015-10-20 02:29:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413543003/1
5 years, 2 months ago (2015-10-20 06:05:27 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/83445) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 2 months ago (2015-10-20 06:07:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413543003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413543003/20001
5 years, 2 months ago (2015-10-20 09:26:58 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-20 11:03:11 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 11:04:10 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9cceab3556c26210436911e806f6abd5aff4ee30
Cr-Commit-Position: refs/heads/master@{#355032}

Powered by Google App Engine
This is Rietveld 408576698