Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 1410223003: bluetooth: mac: Fix incorrect use of AdvertisementData dictionary strings. (Closed)

Created:
5 years, 2 months ago by scheib
Modified:
5 years, 2 months ago
Reviewers:
Nico
CC:
chromium-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bta-merge-uuids-
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: mac: Fix incorrect use of AdvertisementData dictionary strings. String values of the advertisementData dictionary key names [1] were used incorrectly instead of their values. [1] https://developer.apple.com/library/ios/documentation/CoreBluetooth/Reference/CBCentralManagerDelegate_Protocol BUG=541710 Committed: https://crrev.com/bc7f7ea4421a3a91012c174b96db4b3e5260c386 Cr-Commit-Position: refs/heads/master@{#354699}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M device/bluetooth/bluetooth_adapter_mac_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_mac.mm View 1 chunk +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
scheib
5 years, 2 months ago (2015-10-18 02:21:47 UTC) #2
Nico
lgtm, thanks! Usually these constants contain a value identical to their name, but in this ...
5 years, 2 months ago (2015-10-18 02:47:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410223003/1
5 years, 2 months ago (2015-10-18 03:39:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-18 03:44:01 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-18 03:45:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc7f7ea4421a3a91012c174b96db4b3e5260c386
Cr-Commit-Position: refs/heads/master@{#354699}

Powered by Google App Engine
This is Rietveld 408576698