Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1414553004: bluetooth: android: Accumulate advertised UUIDs. (Closed)

Created:
5 years, 2 months ago by scheib
Modified:
5 years, 2 months ago
Reviewers:
armansito
CC:
chromium-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bt-i541710-
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: android: Accumulate advertised UUIDs. Mac OSX and Android behavior differed. Fixing Android to match OSX. DiscoverLowEnergyDeviceWithUpdatedUUIDs test updated to verify that all service UUIDs from advertisement packets are accumulated. BUG=488579, 541710 Committed: https://crrev.com/f22f75c7191b7795ab60a177dd4c704fee9e2a49 Cr-Commit-Position: refs/heads/master@{#355984}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix armansito request, and only report update if UUIDs changed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -18 lines) Patch
M device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothDevice.java View 1 5 chunks +10 lines, -13 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_mac.mm View 1 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_unittest.cc View 1 2 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
scheib
Arman, We implemented different behavior on Android and Mac for what happens if a device ...
5 years, 2 months ago (2015-10-18 02:20:39 UTC) #2
armansito
lgtm with nit https://codereview.chromium.org/1414553004/diff/1/device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothDevice.java File device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothDevice.java (right): https://codereview.chromium.org/1414553004/diff/1/device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothDevice.java#newcode72 device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothDevice.java:72: if (uuidsFromScan != null) { nit: ...
5 years, 2 months ago (2015-10-21 23:03:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414553004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414553004/20001
5 years, 2 months ago (2015-10-24 21:14:19 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-24 22:10:10 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-24 22:10:54 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f22f75c7191b7795ab60a177dd4c704fee9e2a49
Cr-Commit-Position: refs/heads/master@{#355984}

Powered by Google App Engine
This is Rietveld 408576698