Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 1412023002: bluetooth: mac: Only test Low Energy discovery sessions. (Closed)

Created:
5 years, 2 months ago by scheib
Modified:
5 years, 2 months ago
Reviewers:
Nico
CC:
chromium-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@btm-key-strings-
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: mac: Only test Low Energy discovery sessions. Previously simultaneous Low Energy and Classic discovery sessions were used. However, no fake for Mac exists yet for Classic discovery sessions. This resulted in Classic discovery sessions returning in an error. BUG=541710 Committed: https://crrev.com/9cb5c67582d72026ed2db2a5001eb3bc494ec89f Cr-Commit-Position: refs/heads/master@{#354700}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -36 lines) Patch
M device/bluetooth/bluetooth_adapter_unittest.cc View 5 chunks +5 lines, -14 lines 0 comments Download
M device/bluetooth/bluetooth_device_unittest.cc View 15 chunks +15 lines, -15 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/test/bluetooth_test.h View 1 chunk +3 lines, -3 lines 0 comments Download
M device/bluetooth/test/bluetooth_test.cc View 1 chunk +5 lines, -3 lines 2 comments Download

Depends on Patchset:

Messages

Total messages: 8 (2 generated)
scheib
5 years, 2 months ago (2015-10-18 02:22:25 UTC) #2
Nico
rs-lgtm (if you want a real review, as another device/bluetooth/OWNER, but this seems simple enough) ...
5 years, 2 months ago (2015-10-18 02:43:32 UTC) #3
scheib
https://codereview.chromium.org/1412023002/diff/1/device/bluetooth/test/bluetooth_test.cc File device/bluetooth/test/bluetooth_test.cc (right): https://codereview.chromium.org/1412023002/diff/1/device/bluetooth/test/bluetooth_test.cc#newcode34 device/bluetooth/test/bluetooth_test.cc:34: adapter_->StartDiscoverySessionWithFilter( On 2015/10/18 02:43:32, Nico wrote: > Do you ...
5 years, 2 months ago (2015-10-18 04:21:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412023002/1
5 years, 2 months ago (2015-10-18 05:14:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-18 05:43:20 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-18 05:44:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9cb5c67582d72026ed2db2a5001eb3bc494ec89f
Cr-Commit-Position: refs/heads/master@{#354700}

Powered by Google App Engine
This is Rietveld 408576698