Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 1409753008: Rename non-aa rect methods on GrDrawContext in anticipation of making them support aa (Closed)

Created:
5 years, 1 month ago by bsalomon
Modified:
5 years, 1 month ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rename non-aa rect methods on GrDrawContext in anticipation of making them support aa R=joshualitt@google.com Committed: https://skia.googlesource.com/skia/+/a2e69fcdedbd9a7762620e0e9dcdd86596369cff

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -63 lines) Patch
M include/gpu/GrDrawContext.h View 1 1 chunk +12 lines, -12 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrBlurUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawContext.cpp View 2 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/GrTextureParamsAdjuster.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 3 chunks +13 lines, -13 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 3 chunks +15 lines, -15 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (2 generated)
bsalomon
Just a two function rename to reduce the diff of a larger CL.
5 years, 1 month ago (2015-11-05 18:17:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409753008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409753008/1
5 years, 1 month ago (2015-11-05 18:17:07 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 1 month ago (2015-11-05 18:17:08 UTC) #4
joshualitt
On 2015/11/05 18:17:08, commit-bot: I haz the power wrote: > Note for Reviewers: > The ...
5 years, 1 month ago (2015-11-05 18:23:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409753008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409753008/20001
5 years, 1 month ago (2015-11-05 18:29:38 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 18:41:46 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a2e69fcdedbd9a7762620e0e9dcdd86596369cff

Powered by Google App Engine
This is Rietveld 408576698