Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 1395703002: small tidy of benchmarkstream (Closed)

Created:
5 years, 2 months ago by joshua.litt
Modified:
5 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@vb4b
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tweak #

Patch Set 3 : visualbench fixed #

Patch Set 4 : remove debug print #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -59 lines) Patch
M tools/VisualBench/CpuWrappedBenchmark.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M tools/VisualBench/TimingStateMachine.h View 1 chunk +2 lines, -3 lines 0 comments Download
M tools/VisualBench/TimingStateMachine.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M tools/VisualBench/VisualBenchmarkStream.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M tools/VisualBench/VisualBenchmarkStream.cpp View 1 2 2 chunks +19 lines, -13 lines 0 comments Download
M tools/VisualBench/VisualStreamTimingModule.h View 1 2 2 chunks +10 lines, -3 lines 0 comments Download
M tools/VisualBench/VisualStreamTimingModule.cpp View 1 2 3 1 chunk +42 lines, -37 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (7 generated)
joshualitt
ptal
5 years, 2 months ago (2015-10-07 20:20:35 UTC) #2
joshualitt
On 2015/10/07 20:20:35, joshualitt wrote: > ptal pinging
5 years, 2 months ago (2015-10-12 13:48:27 UTC) #3
robertphillips
lgtm
5 years, 2 months ago (2015-10-12 17:01:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395703002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395703002/20001
5 years, 2 months ago (2015-10-14 14:54:12 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/691b6af907e55250a29a7a2a346b63c2026011c3
5 years, 2 months ago (2015-10-14 15:04:26 UTC) #7
joshualitt
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1392833006/ by joshualitt@google.com. ...
5 years, 2 months ago (2015-10-14 21:44:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395703002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395703002/40001
5 years, 2 months ago (2015-10-15 14:04:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395703002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395703002/60001
5 years, 2 months ago (2015-10-15 14:08:46 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 14:18:31 UTC) #16
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/c603c143bb39e8a8dd1b35ad792c4dccb7de3a3a

Powered by Google App Engine
This is Rietveld 408576698