Skip extension management policy checks when installing a bookmark app.

Skip extension management policy checks when installing a bookmark app.

Add to shelf on ChromeOS installs a bookmark app, which uses an
extension under the hood. Extension blacklist policies which prevent
extensions from being installed also disable the add to shelf feature
silently. This CL skips the policy checks for bookmark app installation,
allowing add to shelf to function when extensions are blacklisted.

BUG=545541
R=benwells

Committed: https://crrev.com/07741f84211e9953e97904782561dbb2056cc569
Cr-Commit-Position: refs/heads/master@{#357040}

[dominickn, 2015-10-30 02:12:26]

PTAL, thanks!

[benwells, 2015-10-30 02:24:14]

could we get a test for this?

https://codereview.chromium.org/1409393009/diff/1/chrome/browser/extensions/c...
File chrome/browser/extensions/crx_installer.cc (right):

https://codereview.chromium.org/1409393009/diff/1/chrome/browser/extensions/c...
chrome/browser/extensions/crx_installer.cc:516: // checks if the extension is a
bookmark app.
Why is this skipped for bookmark apps but not for themes?

[dominickn, 2015-10-30 02:42:30]

https://codereview.chromium.org/1409393009/diff/1/chrome/browser/extensions/c...
File chrome/browser/extensions/crx_installer.cc (right):

https://codereview.chromium.org/1409393009/diff/1/chrome/browser/extensions/c...
chrome/browser/extensions/crx_installer.cc:516: // checks if the extension is a
bookmark app.
On 2015/10/30 02:24:13, benwells wrote:
> Why is this skipped for bookmark apps but not for themes?

I'm not sure. The log indicates that the theme exemption for the earlier checks
dates back to at least 2010, but nothing has been added for theme management
policy. I also couldn't find any bugs related to it, so I erred on the side of 

InstallWebApp is completely untested right now. I think it would be better to
have a separate CL adding a number of tests for it rather than packing this one
- I would like to merge this to M47, Thoughts?

[benwells, 2015-10-30 03:24:32]

ok, that all makes sense.

lgtm

[dominickn, 2015-10-30 03:31:16]

The CQ bit was checked by dominickn@chromium.org

[commit-bot: I haz the power, 2015-10-30 03:31:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1409393009/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1409393009/1

[commit-bot: I haz the power, 2015-10-30 03:35:35]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-30 03:37:04]

Patchset 1 (id:??) landed as
https://crrev.com/07741f84211e9953e97904782561dbb2056cc569
Cr-Commit-Position: refs/heads/master@{#357040}