Skip extension management policy checks when installing a bookmark app.

chrome/browser/extensions/crx_installer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/crx_installer.h"
 
 #include <map>
 #include <set>
 
 #include "base/bind.h"
@@ skipping 291 matching lines @@
               extension->GetType()));
         }
       }
     }
 
     if (!valid)
       return CrxInstallError(
           l10n_util::GetStringUTF16(IDS_EXTENSION_MANIFEST_INVALID));
   }
 
-  // The checks below are skipped for themes and external installs.
+  // The checks below are skipped for themes, external installs, and bookmark
+  // apps.
   // TODO(pamg): After ManagementPolicy refactoring is complete, remove this
   // and other uses of install_source_ that are no longer needed now that the
   // SandboxedUnpacker sets extension->location.
-  if (extension->is_theme() || Manifest::IsExternalLocation(install_source_))
+  if (extension->is_theme() || extension->from_bookmark() ||
+      Manifest::IsExternalLocation(install_source_)) {
     return CrxInstallError();
+  }
 
   if (!extensions_enabled_) {
     return CrxInstallError(
         CrxInstallError::ERROR_DECLINED,
         l10n_util::GetStringUTF16(IDS_EXTENSION_INSTALL_NOT_ENABLED));
   }
 
   if (install_cause_ == extension_misc::INSTALL_CAUSE_USER_DOWNLOAD) {
     if (FeatureSwitch::easy_off_store_install()->IsEnabled()) {
       const char kHistogramName[] = "Extensions.OffStoreInstallDecisionEasy";
@@ skipping 174 matching lines @@
             CrxInstallError::ERROR_DECLINED,
             l10n_util::GetStringFUTF16(
                 IDS_EXTENSION_INSTALL_DEPENDENCY_NOT_WHITELISTED,
                 base::UTF8ToUTF16(extension()->name()),
                 base::UTF8ToUTF16(imported_module->name()))));
         return;
       }
     }
   }
 
-  // Run the policy, requirements and blacklist checks in parallel.
-  install_checker_.Start(
-      ExtensionInstallChecker::CHECK_ALL,
-      false /* fail fast */,
-      base::Bind(&CrxInstaller::OnInstallChecksComplete, this));
+  // Run the policy, requirements and blacklist checks in parallel. Skip the
+  // checks if the extension is a bookmark app.

[benwells, 2015/10/30 02:24:13]

Why is this skipped for bookmark apps but not for themes?

[dominickn, 2015/10/30 02:42:30]

I'm not sure. The log indicates that the theme exemption for the earlier checks
dates back to at least 2010, but nothing has been added for theme management
policy. I also couldn't find any bugs related to it, so I erred on the side of 

InstallWebApp is completely untested right now. I think it would be better to
have a separate CL adding a number of tests for it rather than packing this one
- I would like to merge this to M47, Thoughts?

+  if (extension()->from_bookmark()) {
+    CrxInstaller::OnInstallChecksComplete(0);
+  } else {
+    install_checker_.Start(
+        ExtensionInstallChecker::CHECK_ALL,
+        false /* fail fast */,
+        base::Bind(&CrxInstaller::OnInstallChecksComplete, this));
+  }
 }
 
 void CrxInstaller::OnInstallChecksComplete(int failed_checks) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   if (!service_weak_)
     return;
 
   // Check for requirement errors.
   if (!install_checker_.requirement_errors().empty()) {
     if (error_on_unsupported_requirements_) {
@@ skipping 373 matching lines @@
   if (!prefs->DidExtensionEscalatePermissions(extension()->id()))
     return;
 
   if (client_) {
     AddRef();  // Balanced in InstallUIProceed() and InstallUIAbort().
     client_->ConfirmReEnable(this, extension());
   }
 }
 
 }  // namespace extensions