chrome/browser/extensions/crx_installer.h - Issue 1409393009: Skip extension management policy checks when installing a bookmark app.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/crx_installer.h

Issue 1409393009: Skip extension management policy checks when installing a bookmark app. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmark-app-crash-fix

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/crx_installer.h

diff --git a/chrome/browser/extensions/crx_installer.h b/chrome/browser/extensions/crx_installer.h

index 9c109e657a47c4eb099ecd3692008b3abcb8e986..c5e61d37fe3acf1979df7df34ed973baf39fdae4 100644

--- a/chrome/browser/extensions/crx_installer.h

+++ b/chrome/browser/extensions/crx_installer.h

@@ -345,8 +345,8 @@ class CrxInstaller

bool fail_install_if_unexpected_version_;

// Whether manual extension installation is enabled. We can't just check this

- // before trying to install because themes are special-cased to always be

- // allowed.

+ // before trying to install because themes and bookmark apps are special-cased

+ // to always be allowed.

bool extensions_enabled_;

// Whether we're supposed to delete the source file on destruction. Defaults

« no previous file with comments | « no previous file | chrome/browser/extensions/crx_installer.cc » ('j') | chrome/browser/extensions/crx_installer.cc » ('J')