Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1409353002: Clean up wording of client usage expectations (Closed)

Created:
5 years, 2 months ago by Brian Wilkerson
Modified:
5 years, 2 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -206 lines) Patch
M pkg/analysis_server/lib/plugin/analysis/analysis_domain.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/plugin/analysis/navigation/navigation_core.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/plugin/analysis/occurrences/occurrences_core.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/plugin/edit/assist/assist_core.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/plugin/edit/assist/assist_dart.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/plugin/edit/fix/fix_core.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/plugin/edit/fix/fix_dart.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/plugin/edit/utilities/change_builder_core.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/plugin/edit/utilities/change_builder_dart.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/plugin/index/index_core.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart View 149 chunks +149 lines, -149 lines 0 comments Download
M pkg/analysis_server/lib/plugin/protocol/protocol.dart View 7 chunks +7 lines, -7 lines 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/completion_core.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/completion_dart.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_target.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/provisional/refactoring/refactoring_core.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/starter.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_dart_protocol.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/task/model.dart View 14 chunks +17 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
Having not yet found decent names for annotations, and not wanting to hold up the ...
5 years, 2 months ago (2015-10-17 16:47:03 UTC) #2
Paul Berry
lgtm
5 years, 2 months ago (2015-10-19 13:07:53 UTC) #3
Brian Wilkerson
5 years, 2 months ago (2015-10-19 14:46:55 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
27eb09033f880d9832380d37751b193f50a53127 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698