pkg/analysis_server/lib/plugin/analysis/occurrences/occurrences_core.dart - Issue 1409353002: Clean up wording of client usage expectations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/plugin/analysis/occurrences/occurrences_core.dart

Issue 1409353002: Clean up wording of client usage expectations (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/plugin/analysis/navigation/navigation_core.dart ('k') | pkg/analysis_server/lib/plugin/edit/assist/assist_core.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/plugin/analysis/occurrences/occurrences_core.dart

diff --git a/pkg/analysis_server/lib/plugin/analysis/occurrences/occurrences_core.dart b/pkg/analysis_server/lib/plugin/analysis/occurrences/occurrences_core.dart

index eebf54ea562b3a63108e5e2f76f4abf7bae0ce61..ac56afd214e16866f0f8c7885ee859493ae4296f 100644

--- a/pkg/analysis_server/lib/plugin/analysis/occurrences/occurrences_core.dart

+++ b/pkg/analysis_server/lib/plugin/analysis/occurrences/occurrences_core.dart

@@ -12,7 +12,7 @@ import 'package:analyzer/src/generated/source.dart' show Source;

/**

* An object that [OccurrencesContributor]s use to record occurrences into.

- * Clients are not expected to subtype this class.

+ * Clients may not extend, implement or mix-in this class.

abstract class OccurrencesCollector {

/**

@@ -24,7 +24,7 @@ abstract class OccurrencesCollector {

/**

* An object used to produce occurrences.

- * Clients are expected to subtype this class when implementing plugins.

+ * Clients may implement this class when implementing plugins.

abstract class OccurrencesContributor {

/**