Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: pkg/analysis_server/lib/src/provisional/completion/completion_dart.dart

Issue 1409353002: Clean up wording of client usage expectations (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/provisional/completion/completion_dart.dart
diff --git a/pkg/analysis_server/lib/src/provisional/completion/completion_dart.dart b/pkg/analysis_server/lib/src/provisional/completion/completion_dart.dart
index 1ca4180545fd3232c68b8aa305b1ca23b984e702..e52c4332423381b6259f6d7b01b9d6dddcf67038 100644
--- a/pkg/analysis_server/lib/src/provisional/completion/completion_dart.dart
+++ b/pkg/analysis_server/lib/src/provisional/completion/completion_dart.dart
@@ -16,9 +16,9 @@ import 'package:analyzer/src/generated/source.dart';
* file. Completion contributors are long-lived objects and must not retain any
* state between invocations of [computeSuggestions].
*
- * Clients are expected to subtype this class when implementing plugins.
+ * Clients may extend this class when implementing plugins.
*/
-abstract class DartCompletionContributor extends CompletionContributor {
+abstract class DartCompletionContributor implements CompletionContributor {
@override
List<CompletionSuggestion> computeSuggestions(CompletionRequest request) {
if (request is DartCompletionRequest) {
@@ -58,6 +58,8 @@ abstract class DartCompletionContributor extends CompletionContributor {
/**
* The information about a requested list of completions within a Dart file.
+ *
+ * Clients may not extend, implement or mix-in this class.
*/
abstract class DartCompletionRequest extends CompletionRequest {
/**

Powered by Google App Engine
This is Rietveld 408576698