Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Unified Diff: util/mach/child_port_handshake.h

Issue 1409073013: mac: Make crashpad_handler get its receive right from its client (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/win/exception_snapshot_win_test.cc ('k') | util/mach/mach_message_server.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/mach/child_port_handshake.h
diff --git a/util/mach/child_port_handshake.h b/util/mach/child_port_handshake.h
index c1d7ab9a592d3a306faedbe4eb1a0ebd58aa7031..8956daf771ccbb472fe7e2408948d3058f80032c 100644
--- a/util/mach/child_port_handshake.h
+++ b/util/mach/child_port_handshake.h
@@ -87,7 +87,7 @@ class ChildPortHandshakeTest;
//! ChildPortHandshake child_port_handshake;
//! base::ScopedFD server_write_fd = child_port_handshake.ServerWriteFD();
//! std::string server_write_fd_string =
-//! base::StringPrintf("%d", server_write_fd);
+//! base::StringPrintf("%d", server_write_fd.get());
//!
//! pid_t pid = fork();
//! if (pid == 0) {
@@ -97,8 +97,8 @@ class ChildPortHandshakeTest;
//! // server_write_fd. Let the child know what file descriptor to use for
//! // server_write_fd by passing it as argv[1]. Example code for the child
//! // process is below.
-//! CloseMultipleNowOrOnExec(STDERR_FILENO + 1, server_write_fd);
-//! execlp("child", "child", server_write_fd_string.c_str(), nullptr);
+//! CloseMultipleNowOrOnExec(STDERR_FILENO + 1, server_write_fd.get());
+//! execlp("./child", "child", server_write_fd_string.c_str(), nullptr);
//! }
//!
//! // Parent
@@ -122,7 +122,7 @@ class ChildPortHandshakeTest;
//!
//! // Send the receive right to the child process, retaining the send right
//! // for use in the parent process.
-//! if (child_port_handshake.RunClient(receive_right,
+//! if (child_port_handshake.RunClient(receive_right.get(),
//! MACH_MSG_TYPE_MOVE_RECEIVE)) {
//! ignore_result(receive_right.release());
//! }
« no previous file with comments | « snapshot/win/exception_snapshot_win_test.cc ('k') | util/mach/mach_message_server.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698