Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1408793006: Convert "return local_var.Pass();" to "return local_var;". (Closed)

Created:
5 years, 1 month ago by viettrungluu
Modified:
5 years, 1 month ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Convert "return local_var.Pass();" to "return local_var;". (Except where not possible, which is relatively infrequent.) Directories converted include: //mojo/..., //services/..., //shell/... (//apps and //examples were already "clean"). R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b792c80e04ce40c629585c463803da9b89ccc715

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -93 lines) Patch
M mojo/converters/array_string/array_string_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/geometry/geometry_type_converters.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M mojo/converters/input_events/input_events_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/ozone_drm_gpu/ozone_drm_gpu_type_converters.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/converters/surfaces/surfaces_type_converters.cc View 15 chunks +16 lines, -16 lines 0 comments Download
M mojo/dart/embedder/test/dart_to_cpp_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/test/test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/gpu/texture_cache.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/gpu/texture_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/message_pump/handle_watcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/array.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/binding.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/interface_ptr.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/interface_request.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/map.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/equals_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/sample_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/struct_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/tests/type_conversion_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/type_converter.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_definition.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/wrapper_union_class_definition.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/files/c/tests/test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/http_server/cpp/lib/http_server_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/surfaces/cpp/surfaces_utils.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/view_manager/cpp/lib/view.cc View 1 chunk +1 line, -3 lines 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/clipboard/clipboard_standalone_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/files/files_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/gles2/command_buffer_type_conversions.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M services/http_server/http_server_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/js/system/tests/js_to_cpp_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/kiosk_wm/merged_service_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/prediction/dictionary_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/url_response_disk_cache/url_response_disk_cache_db.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/url_response_disk_cache/url_response_disk_cache_db_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/url_response_disk_cache/url_response_disk_cache_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/view_manager/animation_runner_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/view_manager/gesture_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/gesture_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/scheduled_animation_group.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/view_manager_service_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/view_manager_service_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/window_manager/view_target.cc View 1 chunk +1 line, -1 line 0 comments Download
M shell/application_manager/application_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M shell/application_manager/local_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M shell/application_manager/network_fetcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M shell/task_runners.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 1 month ago (2015-10-27 18:18:48 UTC) #1
jamesr
lgtm
5 years, 1 month ago (2015-10-27 18:20:38 UTC) #2
viettrungluu
5 years, 1 month ago (2015-10-27 18:27:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b792c80e04ce40c629585c463803da9b89ccc715 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698