services/js/system/tests/js_to_cpp_tests.cc - Issue 1408793006: Convert "return local_var.Pass();" to "return local_var;".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/js/system/tests/js_to_cpp_tests.cc

Issue 1408793006: Convert "return local_var.Pass();" to "return local_var;". (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/js/system/tests/js_to_cpp_tests.cc

diff --git a/services/js/system/tests/js_to_cpp_tests.cc b/services/js/system/tests/js_to_cpp_tests.cc

index 50f01f67a1134419a4be252ba54b59413791958a..3001a2a0d6b835a255f7841ce09ebfd0343a0cb2 100644

--- a/services/js/system/tests/js_to_cpp_tests.cc

+++ b/services/js/system/tests/js_to_cpp_tests.cc

@@ -98,7 +98,7 @@ js_to_cpp::EchoArgsPtr BuildSampleEchoArgs() {

string_array[1] = "two";

string_array[2] = "three";

args->string_array = string_array.Pass();

- return args.Pass();

+ return args;

}

void CheckSampleEchoArgs(const js_to_cpp::EchoArgs& arg) {