mojo/services/view_manager/cpp/lib/view.cc - Issue 1408793006: Convert "return local_var.Pass();" to "return local_var;".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/view_manager/cpp/lib/view.cc

Issue 1408793006: Convert "return local_var.Pass();" to "return local_var;". (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/view_manager/cpp/lib/view.cc

diff --git a/mojo/services/view_manager/cpp/lib/view.cc b/mojo/services/view_manager/cpp/lib/view.cc

index a42fa1285c2b9a1de36acd8f821fd310a61ff893..aa4b30e1de66386fc93e455433e3121f1445a35c 100644

--- a/mojo/services/view_manager/cpp/lib/view.cc

+++ b/mojo/services/view_manager/cpp/lib/view.cc

@@ -377,9 +377,7 @@ namespace {

ViewportMetricsPtr CreateEmptyViewportMetrics() {

ViewportMetricsPtr metrics = ViewportMetrics::New();

metrics->size = Size::New();

- // TODO(vtl): The |.Pass()| below is only needed due to an MSVS bug; remove it

- // once that's fixed.

- return metrics.Pass();

+ return metrics;

}

} // namespace