Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1408623002: Add cloud_print to the GN build. (Closed)

Created:
5 years, 2 months ago by brettw
Modified:
5 years, 2 months ago
Reviewers:
Dirk Pranke, dpranke, Nico
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add cloud_print to the GN build. There were some existing cloud_print targets that were hooked up only on Linux, but most of the code was Windows-only. This adds the missing targets and should bring us up to GYP parity. Fix the cloud print size_t to int warnings and remove the warning disable from GYP. Move generated resources file from cloud_print/resources.h to cloud_print/service/resources.h to match where the source file is. Cloud print does some messy things to get the content switches constants, including the file directly in its sources and manually setting LINK_CONTENT_STATICALLY for all targets. In GN, this adds a static_switches target in content that does this in an official way. Reland of https://codereview.chromium.org/1397433004/ with grid directory fixes Reland of https://codereview.chromium.org/1393123003/ with warning fixes TBR=dpranke Committed: https://crrev.com/70b359a5032e58cb8309a16068868f63cba00c45 Cr-Commit-Position: refs/heads/master@{#354154}

Patch Set 1 : Old patch #

Patch Set 2 : fixes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+445 lines, -61 lines) Patch
M .gn View 2 chunks +2 lines, -1 line 0 comments Download
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M build/config/win/manifest.gni View 1 chunk +4 lines, -0 lines 0 comments Download
M build/gn_migration.gypi View 2 chunks +5 lines, -5 lines 0 comments Download
A + build/win/require_administrator.manifest View 1 chunk +1 line, -1 line 0 comments Download
M chrome/version_resource_rules.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M cloud_print/BUILD.gn View 2 chunks +28 lines, -10 lines 0 comments Download
M cloud_print/cloud_print.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M cloud_print/cloud_print_resources.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
A + cloud_print/common/BUILD.gn View 1 chunk +8 lines, -11 lines 0 comments Download
M cloud_print/common/common.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M cloud_print/service/BUILD.gn View 2 chunks +50 lines, -6 lines 0 comments Download
M cloud_print/service/service.gyp View 2 chunks +3 lines, -7 lines 0 comments Download
A cloud_print/service/win/BUILD.gn View 1 1 chunk +109 lines, -0 lines 0 comments Download
M cloud_print/service/win/chrome_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/cloud_print_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cloud_print/service/win/cloud_print_service_config.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M cloud_print/service/win/installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/local_security_policy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cloud_print/service/win/service.gyp View 3 chunks +3 lines, -2 lines 0 comments Download
M cloud_print/service/win/service_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/service_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cloud_print/service/win/service_resources.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + cloud_print/virtual_driver/win/BUILD.gn View 1 chunk +7 lines, -5 lines 0 comments Download
A cloud_print/virtual_driver/win/install/BUILD.gn View 1 chunk +110 lines, -0 lines 0 comments Download
M cloud_print/virtual_driver/win/install/virtual_driver_install.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
A cloud_print/virtual_driver/win/port_monitor/BUILD.gn View 1 chunk +61 lines, -0 lines 1 comment Download
M cloud_print/virtual_driver/win/virtual_driver.gypi View 3 chunks +3 lines, -0 lines 0 comments Download
M content/public/common/BUILD.gn View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
brettw
5 years, 2 months ago (2015-10-14 22:31:41 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408623002/20001
5 years, 2 months ago (2015-10-14 22:32:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408623002/20001
5 years, 2 months ago (2015-10-14 22:37:57 UTC) #6
Dirk Pranke
lgtm
5 years, 2 months ago (2015-10-14 22:42:42 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-14 23:43:32 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/70b359a5032e58cb8309a16068868f63cba00c45 Cr-Commit-Position: refs/heads/master@{#354154}
5 years, 2 months ago (2015-10-14 23:45:51 UTC) #10
Nico
https://codereview.chromium.org/1408623002/diff/20001/cloud_print/virtual_driver/win/port_monitor/BUILD.gn File cloud_print/virtual_driver/win/port_monitor/BUILD.gn (right): https://codereview.chromium.org/1408623002/diff/20001/cloud_print/virtual_driver/win/port_monitor/BUILD.gn#newcode17 cloud_print/virtual_driver/win/port_monitor/BUILD.gn:17: print("port_monitor $current_toolchain") whoops! (i'll send you a cl)
5 years, 2 months ago (2015-10-15 23:24:28 UTC) #12
Dirk Pranke
5 years, 2 months ago (2015-10-16 01:31:19 UTC) #13
Message was sent while issue was closed.
lgtm (apart from Nico's catch, of course ;).

Powered by Google App Engine
This is Rietveld 408576698