Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: cloud_print/service/service.gyp

Issue 1408623002: Add cloud_print to the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cloud_print/service/service.gyp
diff --git a/cloud_print/service/service.gyp b/cloud_print/service/service.gyp
index 1eb2b2380086e088b43d9a9849ac6db38da49036..a6171a897e3d6c5a91ea0079124b743513470e78 100644
--- a/cloud_print/service/service.gyp
+++ b/cloud_print/service/service.gyp
@@ -22,19 +22,14 @@
'_ATL_NO_AUTOMATIC_NAMESPACE',
'_ATL_NO_EXCEPTIONS',
],
- 'conditions': [
- ['OS=="win"', {
- # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
- 'msvs_disabled_warnings': [ 4267, ],
- }],
- ],
},
'targets': [
{
+ # GN version: //cloud_print/service:resources
'target_name': 'service_resources',
'type': 'none',
'variables': {
- 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/cloud_print',
+ 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/cloud_print/service',
},
'actions': [
{
@@ -48,6 +43,7 @@
'includes': [ '../../build/grit_target.gypi' ],
},
{
+ # GN version: //cloud_print/service
'target_name': 'cloud_print_service_lib',
'type': 'static_library',
'dependencies': [

Powered by Google App Engine
This is Rietveld 408576698