Chromium Code Reviews| Index: third_party/WebKit/LayoutTests/fast/dom/shadow/create-shadow-root-with-parameter.html |
| diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/create-shadow-root-with-parameter.html b/third_party/WebKit/LayoutTests/fast/dom/shadow/create-shadow-root-with-parameter.html |
| index 1719162a08c23ae7266f6a96a2b4ae6611de07a7..0dedf12e50da6ab6a6a2235f82534866cb80d4b7 100644 |
| --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/create-shadow-root-with-parameter.html |
| +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/create-shadow-root-with-parameter.html |
| @@ -11,12 +11,12 @@ |
| <div id="host4"></div> |
| </body> |
| <script> |
| -debug('Create open shadow root.'); |
| +debug('Attach open shadow root.'); |
| var host1 = document.querySelector('#host1'); |
| -var root1 = host1.createShadowRoot({mode: 'open'}); |
| +var root1 = host1.attachShadow({mode: 'open'}); |
| shouldBeNonNull(root1); |
| -debug('Create closed shadow root.'); |
| +debug('Attach closed shadow root.'); |
| var host2 = document.querySelector('#host2'); |
| shouldBeNonNull("host2.createShadowRoot({mode: 'closed'})"); |
|
kochi
2015/10/15 12:16:18
Forgot to change here?
hayato
2015/10/16 03:47:29
I've rewritten this test.
|
| @@ -25,11 +25,11 @@ var host3 = document.querySelector('#host3'); |
| var root3 = host3.createShadowRoot({}); |
|
kochi
2015/10/15 12:16:18
Ditto.
|
| shouldBeNonNull(root3); |
| -debug('Create shadow root whose mode is neither open nor closed.'); |
| +debug('Attach shadow root whose mode is neither open nor closed.'); |
| var host4 = document.querySelector('#host4'); |
| -shouldThrow("host4.createShadowRoot({mode: 'illegal'})"); |
| +shouldThrow("host4.attachShadow({mode: 'illegal'})"); |
| -debug('Create open shadow root with shadow-dom.js utility.'); |
| +debug('Attach open shadow root with shadow-dom.js utility.'); |
| document.body.appendChild( |
| createDOM('div', {id: 'host5'}, |
| createShadowRoot({mode: 'open'}))); |
|
kochi
2015/10/15 12:16:18
Do you plan to add attachShadow() in shadow-dom.js
|
| @@ -37,7 +37,7 @@ var host5 = document.querySelector('#host5'); |
| var root5 = host5.shadowRoot; |
| shouldBeNonNull(root5); |
| -debug('Create shadow root on already shadowed host will raise InvalidStateError exception.'); |
| -shouldThrow("host1.createShadowRoot({mode: 'open'})"); |
| +debug('Attach shadow root on already shadowed host will raise InvalidStateError exception.'); |
| +shouldThrow("host1.attachShadow({mode: 'open'})"); |
| </script> |
| </html> |