Add Element.attachShadow under the ShadowDOMV1 runtime flag

Add Element.attachShadow under the ShadowDOMV1 runtime flag.

This is basically renaming from `createShadowRoot(ShadowRootInitDict)`,
which was already implemented.

Minimum layout tests are updated accordingly.

Other changes come after this CL.

BUG=531990
Committed: https://crrev.com/c50b98bea4c7bd611fefe7ade6d9bd52fa9af101
Cr-Commit-Position: refs/heads/master@{#354452}

[hayato, 2015-10-15 08:35:24]

hayato@chromium.org changed reviewers:
+ kochi@chromium.org, kojii@chromium.org

[hayato, 2015-10-15 08:35:40]

PTAL

[hayato, 2015-10-15 08:43:04]

https://codereview.chromium.org/1408443003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/OriginsUsingFeatures.h (right):

https://codereview.chromium.org/1408443003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/OriginsUsingFeatures.h:37:
ElementAttachShadow,
kojii@
I guess this is for RAPPOR. Is this change enough to make RAPPOR work?

[kochi, 2015-10-15 08:57:00]

this looks good for the first step.

Could you also look at the layout test failures and
fix them in this CL?

[hayato, 2015-10-15 10:26:07]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-15 10:26:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1408443003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1408443003/40001

[hayato, 2015-10-15 11:43:56]

On 2015/10/15 08:57:00, Takayoshi Kochi wrote:
> this looks good for the first step.
> 
> Could you also look at the layout test failures and
> fix them in this CL?

Thanks. I've fixed them.

[kochi, 2015-10-15 12:16:18]

https://codereview.chromium.org/1408443003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/dom/shadow/create-shadow-root-with-parameter.html
(right):

https://codereview.chromium.org/1408443003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/shadow/create-shadow-root-with-parameter.html:21:
shouldBeNonNull("host2.createShadowRoot({mode: 'closed'})");
Forgot to change here?

https://codereview.chromium.org/1408443003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/shadow/create-shadow-root-with-parameter.html:25:
var root3 = host3.createShadowRoot({});
Ditto.

https://codereview.chromium.org/1408443003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/shadow/create-shadow-root-with-parameter.html:35:
createShadowRoot({mode: 'open'})));
Do you plan to add attachShadow() in shadow-dom.js?

This looks confusing.
(edit: I found your TODO in shadow-dom.js).

https://codereview.chromium.org/1408443003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js
(right):

https://codereview.chromium.org/1408443003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js:1: //
TODO(hayato): Have both createShadowRoot and attachShadow.
Yes!!

[commit-bot: I haz the power, 2015-10-15 12:52:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-15 12:52:34]

Dry run: This issue passed the CQ dry run.

[hayato, 2015-10-16 02:27:44]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-16 02:28:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1408443003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1408443003/60001

[hayato, 2015-10-16 03:47:29]

https://codereview.chromium.org/1408443003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/dom/shadow/create-shadow-root-with-parameter.html
(right):

https://codereview.chromium.org/1408443003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/shadow/create-shadow-root-with-parameter.html:21:
shouldBeNonNull("host2.createShadowRoot({mode: 'closed'})");
On 2015/10/15 12:16:18, Takayoshi Kochi wrote:
> Forgot to change here?

I've rewritten this test.

[kochi, 2015-10-16 04:27:46]

lgtm

[hayato, 2015-10-16 04:34:13]

Thanks. Let me land this CL.

It looks we need another change to make RAPPOR work, but I can do it later.

[hayato, 2015-10-16 04:34:32]

The CQ bit was unchecked by hayato@chromium.org

[hayato, 2015-10-16 04:34:41]

The CQ bit was checked by hayato@chromium.org

[commit-bot: I haz the power, 2015-10-16 04:34:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1408443003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1408443003/60001

[commit-bot: I haz the power, 2015-10-16 05:16:27]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-16 05:17:22]

Patchset 4 (id:??) landed as
https://crrev.com/c50b98bea4c7bd611fefe7ade6d9bd52fa9af101
Cr-Commit-Position: refs/heads/master@{#354452}