third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js - Issue 1408443003: Add Element.attachShadow under the ShadowDOMV1 runtime flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js

Issue 1408443003: Add Element.attachShadow under the ShadowDOMV1 runtime flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cq dry run Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/dom/shadow/create-shadow-root-with-parameter.html ('K') | « third_party/WebKit/LayoutTests/fast/dom/shadow/multiple-shadowroot-with-params-expected.txt ('k') | third_party/WebKit/LayoutTests/inspector/elements/shadow/breadcrumb-shadow-roots.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js

diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js b/third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js

index 19ba8e4e9d6fc2626e786b53b8024ff07c61da4d..651084c92aa36c214b0cb3c5ebadf8364a5633bb 100644

--- a/third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js

+++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js

@@ -1,3 +1,4 @@

+// TODO(hayato): Have both createShadowRoot and attachShadow.

kochi 2015/10/15 12:16:18 Yes!!

function createShadowRoot()

{

var children = Array.prototype.slice.call(arguments);

@@ -41,7 +42,7 @@ function createDOM(tagName, attributes)

shadowRoot = window.internals.createUserAgentShadowRoot(element);

} else {

if (child.parameter && Object.keys(child.parameter).length > 0)

- shadowRoot = element.createShadowRoot(child.parameter);

+ shadowRoot = element.attachShadow(child.parameter);

else

shadowRoot = element.createShadowRoot();

}