Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 140843003: Make GrGLContextInfo have private ptr to GrGLInterface (Closed)

Created:
6 years, 11 months ago by bsalomon
Modified:
6 years, 11 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Make GrGLContextInfo have private ptr to GrGLInterface BUG=skia:2042 Committed: http://code.google.com/p/skia/source/detail?r=13111

Patch Set 1 #

Patch Set 2 : whitespace #

Patch Set 3 : fix #

Total comments: 4

Patch Set 4 : Rob's comment #

Patch Set 5 : upload again, rietveld diff failed. #

Patch Set 6 : tot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -115 lines) Patch
M src/gpu/gl/GrGLContext.h View 1 2 3 4 chunks +30 lines, -50 lines 0 comments Download
M src/gpu/gl/GrGLContext.cpp View 1 2 3 4 5 4 chunks +15 lines, -45 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL.h View 3 chunks +6 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 9 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bsalomon
https://codereview.chromium.org/133413003/
6 years, 11 months ago (2014-01-16 15:34:55 UTC) #1
robertphillips
lgtm + 2 questions https://codereview.chromium.org/140843003/diff/60001/src/gpu/gl/GrGLContext.h File src/gpu/gl/GrGLContext.h (right): https://codereview.chromium.org/140843003/diff/60001/src/gpu/gl/GrGLContext.h#newcode102 src/gpu/gl/GrGLContext.h:102: : INHERITED(that) ? https://codereview.chromium.org/140843003/diff/60001/src/gpu/gl/GrGLContext.h#newcode104 src/gpu/gl/GrGLContext.h:104: ...
6 years, 11 months ago (2014-01-16 15:48:49 UTC) #2
bsalomon
https://codereview.chromium.org/140843003/diff/60001/src/gpu/gl/GrGLContext.h File src/gpu/gl/GrGLContext.h (right): https://codereview.chromium.org/140843003/diff/60001/src/gpu/gl/GrGLContext.h#newcode102 src/gpu/gl/GrGLContext.h:102: On 2014/01/16 15:48:49, robertphillips wrote: > : INHERITED(that) ? ...
6 years, 11 months ago (2014-01-16 17:57:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/140843003/160001
6 years, 11 months ago (2014-01-16 17:57:35 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 18:39:08 UTC) #5
Message was sent while issue was closed. 
Change committed as 13111

Powered by Google App Engine
This is Rietveld 408576698