chrome/test/data/password/password_form.html - Issue 1408423003: [Password Manager] Ignore autofilling invisible password fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/password/password_form.html

Issue 1408423003: [Password Manager] Ignore autofilling invisible password fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added more handling. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/password/ambiguous_password_form.html ('K') | « chrome/test/data/password/ambiguous_password_form.html ('k') | components/autofill/content/renderer/password_autofill_agent.cc » ('j') | components/autofill/content/renderer/password_autofill_agent.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/password/password_form.html

diff --git a/chrome/test/data/password/password_form.html b/chrome/test/data/password/password_form.html

index 473600be951cbd8ed1c0aeb31347d27cf31cea29..602bd3d80809fc97d90c355b9809ce50290d919b 100644

--- a/chrome/test/data/password/password_form.html

+++ b/chrome/test/data/password/password_form.html

@@ -86,5 +86,13 @@ needs to access them by their offsets in the array of the form children.

</form>

+

+<form id='hidden_password_form' method='POST' action='done.html'>

+ <input type='password' id="hidden_password" style="display:none;" autocomplete="off" />

vabr (Chromium) 2015/10/20 16:40:22 Also here, please move the hidden field in between

Pritam Nikam 2015/10/22 09:00:08 Done.

+ <input type='text' id="username" placeholder='Username' />

+ <input type='password' id="password" placeholder='Password' />

+ <input type='submit' />

+</form>

</body>

-</html>

+</html>