Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: chrome/test/data/password/ambiguous_password_form.html

Issue 1408423003: [Password Manager] Ignore autofilling invisible password fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added more handling. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/password/ambiguous_password_form.html
diff --git a/chrome/test/data/password/ambiguous_password_form.html b/chrome/test/data/password/ambiguous_password_form.html
index e2802f9d5c5ba677bc7b0f12654e13c12533859a..ba190d4710246d8f6198ae8315acf5fb06df64d5 100644
--- a/chrome/test/data/password/ambiguous_password_form.html
+++ b/chrome/test/data/password/ambiguous_password_form.html
@@ -36,3 +36,11 @@
<label>New Password: </label> <input type='password' placeholder='New password' />
<input type='submit' />
</form>
+
+<!-- Ambiguous password form with problematic invisible password field. -->
+<form id='hidden_password_form' method='POST' action='done.html'>
+ <input type='password' placeholder='Password' style="display:none;" autocomplete="off" />
+ <label>Username: </label><input type='text' placeholder='Username' />
vabr (Chromium) 2015/10/20 16:40:22 Could you put the hidden password field between us
Pritam Nikam 2015/10/22 09:00:08 Done.
+ <label>Password: </label><input type='password' placeholder='Password' />
+ <input type='submit' />
+</form>

Powered by Google App Engine
This is Rietveld 408576698