Chromium Code Reviews Chromium Code Reviews
Issue 1408423003:
[Password Manager] Ignore autofilling invisible password fields. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 <html> | 1 <html> |
| 2 <body> | 2 <body> |
| 3 <form method="POST" action="done.html" onsubmit="return true;" id="testform"> | 3 <form method="POST" action="done.html" onsubmit="return true;" id="testform"> |
| 4 <input type="text" id="username_field" name="username_field"> | 4 <input type="text" id="username_field" name="username_field"> |
| 5 <input type="password" id="password_field" name="password_field"> | 5 <input type="password" id="password_field" name="password_field"> |
| 6 <input type="submit" id="input_submit_button" name="input_submit_button"> | 6 <input type="submit" id="input_submit_button" name="input_submit_button"> |
| 7 </form> | 7 </form> |
| 8 | 8 |
| 9 <button id="submit_button" name="submit_button" | 9 <button id="submit_button" name="submit_button" |
| 10 onclick="document.getElementById('testform').submit()"> | 10 onclick="document.getElementById('testform').submit()"> |
| (...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 79 </form> | 79 </form> |
| 80 | 80 |
| 81 <!-- Change password form with text field which contains only one digit value. - -> | 81 <!-- Change password form with text field which contains only one digit value. - -> |
| 82 <form action="done.html" id="chg_testform_with_textfield"> | 82 <form action="done.html" id="chg_testform_with_textfield"> |
| 83 <input type="text" id="chg_text_field" name="chg_text_field"/> | 83 <input type="text" id="chg_text_field" name="chg_text_field"/> |
| 84 <input type="password" id="chg_password_withtext_field" name="chg_password_wit htext_field"> | 84 <input type="password" id="chg_password_withtext_field" name="chg_password_wit htext_field"> |
| 85 <input type="password" id="chg_new_password_withtext_username_1" name="chg_new _password_withtext_username_1"> | 85 <input type="password" id="chg_new_password_withtext_username_1" name="chg_new _password_withtext_username_1"> |
| 86 <input type="password" id="chg_new_password_withtext_username_2" name="chg_new _password_withtext_username_2"> | 86 <input type="password" id="chg_new_password_withtext_username_2" name="chg_new _password_withtext_username_2"> |
| 87 <input type="submit" id="chg_submit_withtext_button" name="chg_submit_withtext _button"> | 87 <input type="submit" id="chg_submit_withtext_button" name="chg_submit_withtext _button"> |
| 88 </form> | 88 </form> |
| 89 | |
| 90 <!-- Password form with problematic invisible password field. --> | |
| 91 <form id='hidden_password_form' method='POST' action='done.html'> | |
| 92 <input type='password' id="hidden_password" style="display:none;" autocomplete ="off" /> | |
|
vabr (Chromium)
2015/10/20 16:40:22
Also here, please move the hidden field in between
Pritam Nikam
2015/10/22 09:00:08
Done.
| |
| 93 <input type='text' id="username" placeholder='Username' /> | |
| 94 <input type='password' id="password" placeholder='Password' /> | |
| 95 <input type='submit' /> | |
| 96 </form> | |
| 89 </body> | 97 </body> |
| 90 </html> | 98 </html> |
| OLD | NEW |
