Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Issue 1408373005: Add WindowTreeHostPlatform::GetHost for Android build (Closed)

Created:
5 years, 2 months ago by bshe
Modified:
5 years, 1 month ago
CC:
chromium-reviews, kalyank, sadrul, Hadi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add WindowTreeHostPlatform::GetHost for Android build BUG=507792

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M ui/aura/window_tree_host_platform.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/aura/window_tree_host_platform.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (3 generated)
bshe
Hi Mikhail. Following your suggestion, I uploaded this CL. I am not sure if we ...
5 years, 2 months ago (2015-10-23 20:27:36 UTC) #2
mfomitchev
LGTM. I think this is fine for now. We will need something better once we ...
5 years, 2 months ago (2015-10-23 21:17:00 UTC) #3
mfomitchev
5 years, 1 month ago (2015-10-29 15:53:08 UTC) #5
sadrul
We shouldn't add this. Where do you need it?
5 years, 1 month ago (2015-10-29 15:57:56 UTC) #6
mfomitchev
On 2015/10/29 15:57:56, sadrul wrote: > We shouldn't add this. Where do you need it? ...
5 years, 1 month ago (2015-10-29 16:02:37 UTC) #7
no sievers
but there is one WTH for each popup window (incl. menu) right? so it wouldn't ...
5 years, 1 month ago (2015-10-29 18:02:08 UTC) #9
mfomitchev
On 2015/10/29 18:02:08, sievers wrote: > but there is one WTH for each popup window ...
5 years, 1 month ago (2015-10-29 18:15:54 UTC) #10
no sievers
On 2015/10/29 18:15:54, mfomitchev wrote: > On 2015/10/29 18:02:08, sievers wrote: > > but there ...
5 years, 1 month ago (2015-10-29 18:19:58 UTC) #11
mfomitchev
On 2015/10/29 18:19:58, sievers wrote: > On 2015/10/29 18:15:54, mfomitchev wrote: > > On 2015/10/29 ...
5 years, 1 month ago (2015-10-29 18:39:41 UTC) #12
bshe
5 years, 1 month ago (2015-10-30 14:49:50 UTC) #13
On 2015/10/29 18:39:41, mfomitchev wrote:
> On 2015/10/29 18:19:58, sievers wrote:
> > On 2015/10/29 18:15:54, mfomitchev wrote:
> > > On 2015/10/29 18:02:08, sievers wrote:
> > > > but there is one WTH for each popup window (incl. menu) right? so it
> > wouldn't
> > > > work
> > > 
> > > I *think* we only create a new host in DesktopNativeWidgetAura, and we are
> not
> > > using DesktopNativeWidgetAura currently. I made a change in
> > ChromeViewsDelegate
> > > to allocate NativeWidgetAura instead of DesktopNativeWidgetAura.
> > 
> > But that would still be broken then, since we need a new host (or rather
> > compositor) for all free-floating windows.
> 
> Yeah, it won't work for multi-window. I thought it would be okay for now, and
> then we could fix this up when we add multiwindow support..

Close this issue without submit since it is no longer needed by
https://codereview.chromium.org/1421083003/.
We dont want to add a globe WindowTreeHostPlatform::GetHost.

Powered by Google App Engine
This is Rietveld 408576698