Issue 1408353011: win: generate_dump: PLOG() when OpenProcess() fails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1408353011: win: generate_dump: PLOG() when OpenProcess() fails (Closed)

Created:
5 years, 1 month ago by Mark Mentovai

Modified:
5 years, 1 month ago

Reviewers:
scottmg

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/generate_dump.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

This was going to be my testcase for https://codereview.chromium.org/1429953004/, but it wasn’t a PLOG().

5 years, 1 month ago (2015-11-09 20:27:57 UTC) #2

Mark Mentovai

5 years, 1 month ago (2015-11-09 20:50:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1c1ce825bde03011c35fd3bf70c351bc639c553c (presubmit successful).