tools/generate_dump.cc - Issue 1408353011: win: generate_dump: PLOG() when OpenProcess() fails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/generate_dump.cc

Issue 1408353011: win: generate_dump: PLOG() when OpenProcess() fails (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/generate_dump.cc

diff --git a/tools/generate_dump.cc b/tools/generate_dump.cc

index 0b7d39e3c8e9a8bf1b18f7e37e0dc310ac8ffc75..23b21ef64463d6fb7e98e54b3c32450b5debd8a6 100644

--- a/tools/generate_dump.cc

+++ b/tools/generate_dump.cc

@@ -154,7 +154,7 @@ int GenerateDumpMain(int argc, char* argv[]) {

ScopedKernelHANDLE process(

OpenProcess(kXPProcessAllAccess, false, options.pid));

if (!process.is_valid()) {

- LOG(ERROR) << "could not open process " << options.pid;

+ PLOG(ERROR) << "could not open process " << options.pid;

return EXIT_FAILURE;

}

#endif // OS_MACOSX

« no previous file with comments | « no previous file | no next file » | no next file with comments »