Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: tools/generate_dump.cc

Issue 1408353011: win: generate_dump: PLOG() when OpenProcess() fails (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 if (options.suspend) { 147 if (options.suspend) {
148 LOG(ERROR) << "cannot suspend myself"; 148 LOG(ERROR) << "cannot suspend myself";
149 return EXIT_FAILURE; 149 return EXIT_FAILURE;
150 } 150 }
151 LOG(WARNING) << "operating on myself"; 151 LOG(WARNING) << "operating on myself";
152 } 152 }
153 #elif defined(OS_WIN) 153 #elif defined(OS_WIN)
154 ScopedKernelHANDLE process( 154 ScopedKernelHANDLE process(
155 OpenProcess(kXPProcessAllAccess, false, options.pid)); 155 OpenProcess(kXPProcessAllAccess, false, options.pid));
156 if (!process.is_valid()) { 156 if (!process.is_valid()) {
157 LOG(ERROR) << "could not open process " << options.pid; 157 PLOG(ERROR) << "could not open process " << options.pid;
158 return EXIT_FAILURE; 158 return EXIT_FAILURE;
159 } 159 }
160 #endif // OS_MACOSX 160 #endif // OS_MACOSX
161 161
162 if (options.dump_path.empty()) { 162 if (options.dump_path.empty()) {
163 options.dump_path = base::StringPrintf("minidump.%d", options.pid); 163 options.dump_path = base::StringPrintf("minidump.%d", options.pid);
164 } 164 }
165 165
166 { 166 {
167 #if defined(OS_MACOSX) 167 #if defined(OS_MACOSX)
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 221
222 #if defined(OS_POSIX) 222 #if defined(OS_POSIX)
223 int main(int argc, char* argv[]) { 223 int main(int argc, char* argv[]) {
224 return crashpad::GenerateDumpMain(argc, argv); 224 return crashpad::GenerateDumpMain(argc, argv);
225 } 225 }
226 #elif defined(OS_WIN) 226 #elif defined(OS_WIN)
227 int wmain(int argc, wchar_t* argv[]) { 227 int wmain(int argc, wchar_t* argv[]) {
228 return crashpad::ToolSupport::Wmain(argc, argv, crashpad::GenerateDumpMain); 228 return crashpad::ToolSupport::Wmain(argc, argv, crashpad::GenerateDumpMain);
229 } 229 }
230 #endif // OS_POSIX 230 #endif // OS_POSIX
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698