Disable insertion points in v1 shadow trees.

Disable insertion points in v1 shadow trees.

Make <content> and <shadow> inert in v1 shadow trees.
In other words, v0 distribution doesn't happen in v1 shadow trees.

See the rule2 of the doc [1].

[1] https://github.com/w3c/webcomponents/blob/gh-pages/proposals/shadow-dom-v1-in-blink.md#unified-distribution

BUG=531990
Committed: https://crrev.com/5a3f642bb287885b7f4c6b15eaf6133b90954945
Cr-Commit-Position: refs/heads/master@{#355239}

[hayato, 2015-10-19 06:14:08]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-19 06:14:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1408203003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1408203003/1

[commit-bot: I haz the power, 2015-10-19 07:06:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-19 07:06:34]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hayato, 2015-10-19 09:21:26]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[hayato, 2015-10-19 09:21:29]

dry-run

[commit-bot: I haz the power, 2015-10-19 09:21:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1408203003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1408203003/20001

[commit-bot: I haz the power, 2015-10-19 10:10:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-19 10:10:02]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hayato, 2015-10-20 04:58:40]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[hayato, 2015-10-20 04:58:44]

rebased

[commit-bot: I haz the power, 2015-10-20 04:59:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1408203003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1408203003/40001

[commit-bot: I haz the power, 2015-10-20 05:03:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-20 05:03:07]

Dry run: Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[hayato, 2015-10-20 07:55:14]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[hayato, 2015-10-20 07:55:16]

add a test

[commit-bot: I haz the power, 2015-10-20 07:55:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1408203003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1408203003/60001

[hayato, 2015-10-20 08:12:05]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[hayato, 2015-10-20 08:12:08]

remove expectations

[commit-bot: I haz the power, 2015-10-20 08:12:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1408203003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1408203003/80001

[hayato, 2015-10-20 09:22:10]

Description was changed from

==========
Disable insertion points in v1 shadow trees.

BUG=
==========

to

==========
Disable insertion points in v1 shadow trees.

Make <content> and <shadow> inert in v1 shadow trees.
In other words, v0 distribution doesn't happen in v1 shadow trees.

See the rule2 of the doc [1]. 

[1]
https://github.com/w3c/webcomponents/blob/gh-pages/proposals/shadow-dom-v1-in...

BUG=531990
==========

[hayato, 2015-10-20 09:23:28]

hayato@chromium.org changed reviewers:
+ kochi@chromium.org, kojii@chromium.org

[hayato, 2015-10-20 09:23:28]

PTAL

[commit-bot: I haz the power, 2015-10-20 09:29:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-20 09:29:07]

Dry run: This issue passed the CQ dry run.

[kojii, 2015-10-21 02:27:59]

lgtm

[kochi, 2015-10-21 03:13:51]

https://codereview.chromium.org/1408203003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/shadow/ElementShadow.h (right):

https://codereview.chromium.org/1408203003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/shadow/ElementShadow.h:85: void
distributeV1();
Do we use "V1" in the source code?
I guess V0 is okay, will deprecate eventually, but I'm not sure V1 is
a proper naming.

The same goes to isV1() below.

Eventually we are "V1 by default", which means we should not check if
this is V1 or not... then I would think that isV0() check is more
natural way for the time being to special-case old behavior.

e.g.

void distribute()
{
   if (isV0) {
       distributeV0();
       return;
    }

    //... do what is expected in V1
}

[hayato, 2015-10-21 05:17:10]

On 2015/10/21 03:13:51, Takayoshi Kochi wrote:
>
https://codereview.chromium.org/1408203003/diff/80001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/dom/shadow/ElementShadow.h (right):
> 
>
https://codereview.chromium.org/1408203003/diff/80001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/dom/shadow/ElementShadow.h:85: void
> distributeV1();
> Do we use "V1" in the source code?

I prefer using V1 explicitly as long as we have v0 code.

We might want to remove a term of v1 after we remove v0 code. Until that
happens, explicit is better than implicit.

> I guess V0 is okay, will deprecate eventually, but I'm not sure V1 is
> a proper naming.
> 
> The same goes to isV1() below.
> 
> Eventually we are "V1 by default", which means we should not check if
> this is V1 or not... then I would think that isV0() check is more
> natural way for the time being to special-case old behavior.
> 
> e.g.
> 
> void distribute()
> {
>    if (isV0) {
>        distributeV0();
>        return;
>     }
> 
>     //... do what is expected in V1
> }

That's not equivalent since v0 doesn't include an user-agent shadow root.

[hayato, 2015-10-21 05:18:29]

The CQ bit was checked by hayato@chromium.org

[commit-bot: I haz the power, 2015-10-21 05:18:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1408203003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1408203003/80001

[commit-bot: I haz the power, 2015-10-21 05:22:44]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-10-21 05:23:47]

Patchset 5 (id:??) landed as
https://crrev.com/5a3f642bb287885b7f4c6b15eaf6133b90954945
Cr-Commit-Position: refs/heads/master@{#355239}