third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js - Issue 1408203003: Disable insertion points in v1 shadow trees.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js

Issue 1408203003: Disable insertion points in v1 shadow trees. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v1-youngest-shadow-root-ref

Patch Set: remove expectations Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/shadow/get-destination-insertion-points-re-distribution-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/dom/shadow/v0-inert-features-in-v1-shadow-trees.html » ('j') | third_party/WebKit/Source/core/dom/shadow/ElementShadow.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js

diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js b/third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js

index 54018965a16b9bc79846ffc6c038ace0d14dd907..4f7cf9f53954d6d20bd3877c4b7f914ab597899f 100644

--- a/third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js

+++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js

@@ -64,10 +64,15 @@ function convertTemplatesToShadowRootsWithin(node) {

var nodes = node.querySelectorAll("template");

for (var i = 0; i < nodes.length; ++i) {

var template = nodes[i];

+ var mode = template.getAttribute("data-mode");

var parent = template.parentNode;

parent.removeChild(template);

- var shadowRoot = parent.createShadowRoot();

+ var shadowRoot;

+ if (!mode) {

+ shadowRoot = parent.createShadowRoot();

+ } else {

+ shadowRoot = parent.attachShadow({'mode': mode});

+ }

if (template.id)

shadowRoot.id = template.id;

var fragments = document.importNode(template.content, true);