Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp

Issue 1408203003: Disable insertion points in v1 shadow trees. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v1-youngest-shadow-root-ref
Patch Set: remove expectations Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp
diff --git a/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp b/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp
index ccf05a80afca47ba0092611129ff765fe93df283..024e3647d811dc7f998bf3f6d685313811209c35 100644
--- a/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp
+++ b/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp
@@ -276,6 +276,14 @@ const DestinationInsertionPoints* ElementShadow::destinationInsertionPointsFor(c
void ElementShadow::distribute()
{
+ if (isV1())
+ distributeV1();
+ else
+ distributeV0();
+}
+
+void ElementShadow::distributeV0()
+{
host()->setNeedsStyleRecalc(SubtreeStyleChange, StyleChangeReasonForTracing::create(StyleChangeReason::Shadow));
WillBeHeapVector<RawPtrWillBeMember<HTMLShadowElement>, 32> shadowInsertionPoints;
DistributionPool pool(*host());
@@ -318,6 +326,11 @@ void ElementShadow::distribute()
InspectorInstrumentation::didPerformElementShadowDistribution(host());
}
+void ElementShadow::distributeV1()
+{
+ // TODO(hayato): Implement this
+}
+
void ElementShadow::didDistributeNode(const Node* node, InsertionPoint* insertionPoint)
{
#if ENABLE(OILPAN)

Powered by Google App Engine
This is Rietveld 408576698