Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: util/win/critical_section_with_debug_info.cc

Issue 1408123006: Tidy up to enable C4800 on Windows (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: . Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: util/win/critical_section_with_debug_info.cc
diff --git a/util/win/critical_section_with_debug_info.cc b/util/win/critical_section_with_debug_info.cc
index dc1a2dbaa235e08a2bf005571d626e4641d48fb0..7109849d1cc7747369ba38848f2ec5602ef5f1a9 100644
--- a/util/win/critical_section_with_debug_info.cc
+++ b/util/win/critical_section_with_debug_info.cc
@@ -28,7 +28,7 @@ BOOL CrashpadInitializeCriticalSectionEx(
static const auto initialize_critical_section_ex =
GET_FUNCTION_REQUIRED(L"kernel32.dll", ::InitializeCriticalSectionEx);
bool ret =
Mark Mentovai 2015/10/22 21:22:40 …this one can even be BOOL…
scottmg 2015/10/22 21:28:27 Done.
- initialize_critical_section_ex(critical_section, spin_count, flags);
+ !!initialize_critical_section_ex(critical_section, spin_count, flags);
if (!ret) {
PLOG(ERROR) << "InitializeCriticalSectionEx";
return false;
@@ -65,8 +65,8 @@ bool InitializeCriticalSectionWithDebugInfoIfPossible(
return true;
}
- return CrashpadInitializeCriticalSectionEx(
- critical_section, 0, RTL_CRITICAL_SECTION_FLAG_FORCE_DEBUG_INFO);
+ return !!CrashpadInitializeCriticalSectionEx(
Mark Mentovai 2015/10/22 21:22:40 …then you don’t need to change this.
scottmg 2015/10/22 21:28:27 Done.
+ critical_section, 0, RTL_CRITICAL_SECTION_FLAG_FORCE_DEBUG_INFO);
}
} // namespace crashpad

Powered by Google App Engine
This is Rietveld 408576698