Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: client/settings.cc

Issue 1408123006: Tidy up to enable C4800 on Windows (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: . Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« client/crashpad_client_win.cc ('K') | « client/crashpad_client_win.cc ('k') | minidump/minidump_file_writer.cc » ('j') | util/win/critical_section_with_debug_info.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/settings.cc
diff --git a/client/settings.cc b/client/settings.cc
index 7f126ad70d12e79d3ae70a4f1cadcd14e4d908d5..561414d6e3ced6184d193e760900fd578c252dc9 100644
--- a/client/settings.cc
+++ b/client/settings.cc
@@ -253,7 +253,7 @@ bool Settings::ReadSettings(FileHandle handle,
if (log_read_error)
read_result = LoggingReadFile(handle, out_data, sizeof(*out_data));
else
- read_result = ReadFile(handle, out_data, sizeof(*out_data));
+ read_result = ReadFile(handle, out_data, sizeof(*out_data)) >= 0;
Mark Mentovai 2015/10/22 21:22:40 Oops, this was my mistake. == sizeof(*out_data) w
scottmg 2015/10/22 21:28:27 Done.
scottmg 2015/10/22 21:29:54 Let's hope sizeof(Data) != 0xffffffff bytes!
if (!read_result)
return false;
« client/crashpad_client_win.cc ('K') | « client/crashpad_client_win.cc ('k') | minidump/minidump_file_writer.cc » ('j') | util/win/critical_section_with_debug_info.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698