Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1405383006: [sync] Componentize strings used by ProfileSyncService (Closed)

Created:
5 years, 1 month ago by blundell
Modified:
5 years, 1 month ago
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@pss_switches_strings
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sync] Componentize strings used by ProfileSyncService This CL componentizes strings used by ProfileSyncService in anticipation of componentizing that class for integration on iOS. BUG=512825 TBR=jochen Committed: https://crrev.com/aa263a8c1ca63baf4ce1ad5521987162d2d46bec Cr-Commit-Position: refs/heads/master@{#358292}

Patch Set 1 #

Patch Set 2 : Bugfix #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -13 lines) Patch
M build/ios/grit_whitelist.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/foreign_session_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
A components/browser_sync_strings.grdp View 1 chunk +12 lines, -0 lines 0 comments Download
M components/components_strings.grd View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (7 generated)
blundell
5 years, 1 month ago (2015-11-03 16:07:38 UTC) #2
Nicolas Zea
lgtm
5 years, 1 month ago (2015-11-03 18:32:41 UTC) #3
blundell
TBR=jochen@ for //chrome/browser/DEPS and //chrome/browser/ui/webui trivial changes
5 years, 1 month ago (2015-11-06 08:28:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405383006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405383006/40001
5 years, 1 month ago (2015-11-06 08:29:15 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/127287)
5 years, 1 month ago (2015-11-06 09:11:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405383006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405383006/40001
5 years, 1 month ago (2015-11-06 09:19:57 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-06 09:52:06 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 09:53:13 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/aa263a8c1ca63baf4ce1ad5521987162d2d46bec
Cr-Commit-Position: refs/heads/master@{#358292}

Powered by Google App Engine
This is Rietveld 408576698