Remove ImmersiveModeController::MaybeStartReveal() / ImmersiveModeController::CancelReveal()

Remove ImmersiveModeController::MaybeStartReveal() / ImmersiveModeController::CancelReveal()

BUG=188567
Test=Manual, see steps below
1) Run chrome with --ash-immersive-fullscreen
2) Enter immersive fullscreen by pressing F11
3) Wait for the animation hiding the top-of-window views to finish
4) Verify that Alt+D reveals the top-of-window views
5) Click in the web contents to close the top-of-window views
6) Verity that Alt+Shift+T reveals the top-of-window views

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193543

[pkotwicz, 2013-04-10 23:31:02]

James, can you please take a look?
I replaced MaybeStartReveal() / CancelReveal() with GetRevealedLock(). I think
this is clearer. (Though I dislike the long comments).
I removed the calls to MaybeStartReveal() in FocusBookmarksToolbar() and
FocusAppMenu() because those are disabled in fullscreen. The code we had in
FocusBookmarksToolbar() would not have revealed the top-of-window views even if
we allowed focusing the bookmarks bar in fullscreen.

[James Cook, 2013-04-10 23:41:29]

I like it!  LGTM

https://codereview.chromium.org/14080005/diff/2001/chrome/browser/ui/views/fr...
File chrome/browser/ui/views/frame/browser_view.cc (left):

https://codereview.chromium.org/14080005/diff/2001/chrome/browser/ui/views/fr...
chrome/browser/ui/views/frame/browser_view.cc:1015: // The view doesn't need to
be revealed after all.
Ooh, cleaning this up is nice!

https://codereview.chromium.org/14080005/diff/2001/chrome/browser/ui/views/fr...
File chrome/browser/ui/views/frame/immersive_mode_controller.h (left):

https://codereview.chromium.org/14080005/diff/2001/chrome/browser/ui/views/fr...
chrome/browser/ui/views/frame/immersive_mode_controller.h:51: virtual void
MaybeStartReveal() = 0;
Awesome that this simplifies the interface.

[commit-bot: I haz the power, 2013-04-10 23:48:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/14080005/2001

[commit-bot: I haz the power, 2013-04-10 23:59:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/14080005/16001

[commit-bot: I haz the power, 2013-04-11 02:22:02]

Change committed as 193543