chrome/browser/ui/views/frame/immersive_mode_controller.h - Issue 14080005: Remove ImmersiveModeController::MaybeStartReveal() / ImmersiveModeController::CancelReveal()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/immersive_mode_controller.h

Issue 14080005: Remove ImmersiveModeController::MaybeStartReveal() / ImmersiveModeController::CancelReveal() (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Rebased Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | chrome/browser/ui/views/frame/immersive_mode_controller_ash.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/immersive_mode_controller.h

diff --git a/chrome/browser/ui/views/frame/immersive_mode_controller.h b/chrome/browser/ui/views/frame/immersive_mode_controller.h

index d41740b682db785e0b7b3e8ad7329c99166e926b..80d5725c1aa6f2bfab8e664952bf547ce0e5c8b4 100644

--- a/chrome/browser/ui/views/frame/immersive_mode_controller.h

+++ b/chrome/browser/ui/views/frame/immersive_mode_controller.h

@@ -46,13 +46,6 @@ class ImmersiveModeController {

// the reveal view's layer is on top and hence visible over web contents.

virtual void MaybeStackViewAtTop() = 0;

- // Shows the reveal view if immersive mode is enabled. Used when focus is

- // placed in the location bar, tools menu, etc.

- virtual void MaybeStartReveal() = 0;

- // Immediately hides the reveal view, without animating.

- virtual void CancelReveal() = 0;

// Returns a lock which will keep the top-of-window views revealed for its

// lifetime. Several locks can be obtained. When all of the locks are

// destroyed, if immersive mode is enabled and there is nothing else keeping

« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | chrome/browser/ui/views/frame/immersive_mode_controller_ash.h » ('j') | no next file with comments »