chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc - Issue 14080005: Remove ImmersiveModeController::MaybeStartReveal() / ImmersiveModeController::CancelReveal()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc

Issue 14080005: Remove ImmersiveModeController::MaybeStartReveal() / ImmersiveModeController::CancelReveal() (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Rebased Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc ('k') | chrome/browser/ui/views/frame/immersive_mode_controller_stub.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc

diff --git a/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc b/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc

index 78b610041cb0fd0ed39acd8fc5e0b6d710f74456..9b151f66141a84e6369372e5e6ee65f7372e4c9d 100644

--- a/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc

+++ b/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc

@@ -122,8 +122,9 @@ IN_PROC_BROWSER_TEST_F(ImmersiveModeControllerAshTest, ImmersiveMode) {

EXPECT_EQ(GetRectInWidget(browser_view).y() + Tab::GetImmersiveHeight(),

GetRectInWidget(contents_view).y());

- // Ending a reveal keeps us in immersive mode, but toolbar goes invisible.

- controller->CancelReveal();

+ // End reveal by moving the mouse off the top-of-window views. We

+ // should stay in immersive mode, but the toolbar should go invisible.

+ controller->SetMouseHoveredForTest(false);

EXPECT_TRUE(controller->IsEnabled());

EXPECT_TRUE(controller->ShouldHideTopViews());

EXPECT_FALSE(controller->IsRevealed());

@@ -389,7 +390,6 @@ IN_PROC_BROWSER_TEST_F(ImmersiveModeControllerAshTest, RevealedLock) {

// 2) Test that acquiring a revealed state lock reveals the top-of-window

// views if they are hidden.

- controller->CancelReveal();

EXPECT_FALSE(controller->IsRevealed());

lock1.reset(controller->GetRevealedLock());

EXPECT_TRUE(controller->IsRevealed());