[Offline pages] Setting a proper NTP incognito message for offline pages

[Offline pages] Setting a proper NTP incognito message for offline pages

When offline pages are enabled, it updating NTP message
OLD: Any files you download or bookmarks you create will be kept.
NEW: Any downloaded files or saved pages will be kept.

BUG=491352
Committed: https://crrev.com/e632994a3a210b1482afddb69ac9ebbc331a2ed5
Cr-Commit-Position: refs/heads/master@{#357102}

[fgorski, 2015-10-29 18:05:36]

Description was changed from

==========
[Offline pages] Setting a proper NTP incognito message for offline pages

BUG=491352
==========

to

==========
[Offline pages] Setting a proper NTP incognito message for offline pages

When offline pages are enabled, it updating NTP message
OLD: Any files you download or bookmarks you create will be kept.
NEW: Any downloaded files or saved pages will be kept.


BUG=491352
==========

[fgorski, 2015-10-29 18:05:36]

fgorski@chromium.org changed reviewers:
+ dvadym@chromium.org, newt@chromium.org

[fgorski, 2015-10-29 18:06:36]

Please take a look.
newt@ as owner
dvadym@ to approve the content of a message on Incognito NTP from the privacy
perspective.

[newt (away), 2015-10-29 21:52:09]

lgtm after comment

https://codereview.chromium.org/1407903004/diff/20001/chrome/android/java/str...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/1407903004/diff/20001/chrome/android/java/str...
chrome/android/java/strings/android_chrome_strings.grd:1927: <message
name="IDS_OFFLINE_PAGES_NEW_TAB_INCOGNITO_MESSAGE" desc="Message shown when a
user opens an incognito tab explaining incognito mode when offline pages feature
is enabled">
I'd put this message next to IDS_NEW_TAB_INCOGNITO_MESSAGE, since eventually
this will replace IDS_NEW_TAB_INCOGNITO_MESSAGE and logically belongs with the
NTP messages not offline message. Also, the description can (and probably
should) be the same as for IDS_NEW_TAB_INCOGNITO_MESSAGE. (The fact that offline
pages are enabled is mostly irrelevant to the translators)

[dvadym, 2015-10-30 13:36:03]

LGTM from privacy perspective

[fgorski, 2015-10-30 14:10:41]

Comment addressed.

Thanks for the review.

https://codereview.chromium.org/1407903004/diff/20001/chrome/android/java/str...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/1407903004/diff/20001/chrome/android/java/str...
chrome/android/java/strings/android_chrome_strings.grd:1927: <message
name="IDS_OFFLINE_PAGES_NEW_TAB_INCOGNITO_MESSAGE" desc="Message shown when a
user opens an incognito tab explaining incognito mode when offline pages feature
is enabled">
On 2015/10/29 21:52:09, newt wrote:
> I'd put this message next to IDS_NEW_TAB_INCOGNITO_MESSAGE, since eventually
> this will replace IDS_NEW_TAB_INCOGNITO_MESSAGE and logically belongs with the
> NTP messages not offline message. Also, the description can (and probably
> should) be the same as for IDS_NEW_TAB_INCOGNITO_MESSAGE. (The fact that
offline
> pages are enabled is mostly irrelevant to the translators)

Done.

[fgorski, 2015-10-30 14:37:54]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2015-10-30 14:37:54]

The patchset sent to the CQ was uploaded after l-g-t-m from dvadym@chromium.org,
newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1407903004/#ps40001
(title: "Moving the message in the strings file and updating description for
translators")

[commit-bot: I haz the power, 2015-10-30 14:39:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1407903004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1407903004/40001

[commit-bot: I haz the power, 2015-10-30 14:45:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-30 14:45:54]

Patchset 3 (id:??) landed as
https://crrev.com/e632994a3a210b1482afddb69ac9ebbc331a2ed5
Cr-Commit-Position: refs/heads/master@{#357102}