chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java - Issue 1407903004: [Offline pages] Setting a proper NTP incognito message for offline pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java

Issue 1407903004: [Offline pages] Setting a proper NTP incognito message for offline pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moving the message in the strings file and updating description for translators Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/layout/new_tab_page_incognito.xml ('k') | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java

index 16fcbf303a284fcd3cab63856d592bc1645f3c29..df7984c0f6255ba1c0f4fd634092104bbd595c38 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java

@@ -8,6 +8,7 @@ import android.app.Activity;

import android.graphics.Canvas;

import android.view.LayoutInflater;

import android.view.View;

+import android.widget.TextView;

import org.chromium.base.ApiCompatibilityUtils;

import org.chromium.base.VisibleForTesting;

@@ -17,6 +18,7 @@ import org.chromium.chrome.browser.UrlConstants;

import org.chromium.chrome.browser.compositor.layouts.content.InvalidationAwareThumbnailProvider;

import org.chromium.chrome.browser.help.HelpAndFeedback;

import org.chromium.chrome.browser.ntp.IncognitoNewTabPageView.IncognitoNewTabPageManager;

+import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;

import org.chromium.chrome.browser.profiles.Profile;

/**

@@ -68,6 +70,13 @@ public class IncognitoNewTabPage implements NativePage, InvalidationAwareThumbna

mIncognitoNewTabPageView =

(IncognitoNewTabPageView) inflater.inflate(R.layout.new_tab_page_incognito, null);

mIncognitoNewTabPageView.initialize(mIncognitoNewTabPageManager);

+ if (OfflinePageBridge.isEnabled()) {

+ TextView newTabIncognitoMessage = (TextView) mIncognitoNewTabPageView.findViewById(

+ R.id.new_tab_incognito_message);

+ newTabIncognitoMessage.setText(activity.getResources().getString(

+ R.string.offline_pages_new_tab_incognito_message));

+ }

}

/**