Chromium Code Reviews
Help | Chromium Project | Sign in
(9)

Issue 1407633003: [css-grid] Implementation of Baseline Self-Alignment

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 4 months ago by jfernandez
Modified:
6 days, 4 hours ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, jfernandez, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, Manuel Rego, svillar, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Implementation of Baseline Self-Alignment The CSS Box Alignment spec defines different Baseline alignment for the Content-Alignment and Self-Alignment properties. This patch address just the Baseline Self-Alignment logic for grid items. Additionally, Baseline alignment should work in both row and column axis and this patches provides support only for row-axis alignment. Finally, since last-baseline is still under risk of being dropped during the CR period, it won't be implemented for the time being. BUG=412410

Patch Set 1 : Preliminary approach. #

Total comments: 7

Patch Set 2 : New approach. #

Patch Set 3 : Fixed several bug and added new tests. #

Total comments: 8

Patch Set 4 : Applied suggested changes. #

Total comments: 10

Patch Set 5 : New approach. #

Patch Set 6 : Refactoring and code cleanup. #

Patch Set 7 : Patch rebased and applied several refactoring and code clean up. #

Total comments: 13

Patch Set 8 : Applied suggested changes and resolved the intrinsic size issues. #

Total comments: 4

Patch Set 9 : Update width and height based on baseline without altering the intrinsic size. #

Patch Set 10 : Update intrinsic size and compute baseline after step 2 to deal with percentage items. #

Total comments: 17

Patch Set 11 : Get advantage of recomputing the intrinsic size to solve the issues with orthogonal flows. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3181 lines, -60 lines) Patch
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-baseline.html View 1 2 3 1 chunk +109 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-baseline-vertical.html View 1 2 3 1 chunk +133 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-baseline.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-spanning-and-orthogonal-flows.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-01.html View 1 2 3 4 5 6 7 8 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-01-expected.html View 1 2 3 4 5 6 7 8 1 chunk +51 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-02.html View 1 2 3 4 5 6 7 8 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-02-b.html View 1 2 3 4 5 6 7 8 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-02-b-expected.html View 1 2 3 4 5 6 7 8 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-02-expected.html View 1 2 3 4 5 6 7 8 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-03.html View 1 2 3 4 5 6 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-03-expected.html View 1 2 3 4 5 6 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-04.html View 1 2 3 4 5 6 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-04-expected.html View 1 2 3 4 5 6 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-05.html View 1 2 3 4 5 6 7 8 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-05-expected.html View 1 2 3 4 5 6 7 8 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-06.html View 1 2 3 4 5 6 7 8 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-06-expected.html View 1 2 3 4 5 6 7 8 1 chunk +49 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-07.html View 1 2 3 4 5 6 7 8 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-07-expected.html View 1 2 3 4 5 6 7 8 1 chunk +57 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-horiz-01.html View 1 2 3 4 5 6 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-horiz-01-expected.html View 1 2 3 4 5 6 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-horiz-02.html View 1 2 3 4 5 6 1 chunk +57 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-horiz-02-expected.html View 1 2 3 4 5 6 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-horiz-03.html View 1 2 3 4 5 6 1 chunk +53 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-horiz-03-expected.html View 1 2 3 4 5 6 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-horiz-04.html View 1 2 3 4 5 6 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-horiz-04-expected.html View 1 2 3 4 5 6 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-horiz-05.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-horiz-05-expected.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-horiz-06.html View 1 2 3 4 5 6 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-horiz-06-expected.html View 1 2 3 4 5 6 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-horiz-07.html View 1 2 3 4 5 6 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-horiz-07-expected.html View 1 2 3 4 5 6 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-two-dimensional.html View 1 2 3 4 1 chunk +166 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-lr-01.html View 1 2 3 4 5 6 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-lr-01-expected.html View 1 2 3 4 5 6 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-lr-02.html View 1 2 3 4 5 6 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-lr-02-expected.html View 1 2 3 4 5 6 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-lr-03.html View 1 2 3 4 5 6 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-lr-03-expected.html View 1 2 3 4 5 6 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-lr-04.html View 1 2 3 4 5 6 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-lr-04-expected.html View 1 2 3 4 5 6 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-lr-05.html View 1 2 3 4 5 6 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-lr-05-expected.html View 1 2 3 4 5 6 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-lr-06.html View 1 2 3 4 5 6 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-lr-06-expected.html View 1 2 3 4 5 6 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-lr-07.html View 1 2 3 4 5 6 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-lr-07-expected.html View 1 2 3 4 5 6 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-rl-01.html View 1 2 3 4 5 6 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-rl-01-expected.html View 1 2 3 4 5 6 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-rl-02.html View 1 2 3 4 5 6 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-rl-02-expected.html View 1 2 3 4 5 6 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-rl-03.html View 1 2 3 4 5 6 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-rl-03-expected.html View 1 2 3 4 5 6 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-rl-04.html View 1 2 3 4 5 6 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-rl-04-expected.html View 1 2 3 4 5 6 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-rl-05.html View 1 2 3 4 5 6 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-rl-05-expected.html View 1 2 3 4 5 6 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-rl-06.html View 1 2 3 4 5 6 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-rl-06-expected.html View 1 2 3 4 5 6 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-rl-07.html View 1 2 3 4 5 6 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-vertical-rl-07-expected.html View 1 2 3 4 5 6 1 chunk +32 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows.html View 1 2 3 4 5 6 7 8 9 10 13 chunks +26 lines, -26 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-percentages-and-orthogonal-flows.html View 1 2 3 4 5 6 7 8 9 10 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/repeating-layout-must-produce-the-same-results.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-alignment.css View 1 2 3 4 5 6 4 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/BaselineAlignment.h View 1 2 3 4 5 6 7 1 chunk +84 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/BaselineAlignment.cpp View 1 2 3 4 5 6 7 1 chunk +102 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.h View 1 2 3 4 5 6 7 8 9 4 chunks +40 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 1 2 3 4 5 6 7 8 9 10 15 chunks +252 lines, -20 lines 0 comments Download
Trybot results: Sign in to try more bots
Commit queue not available (can’t edit this change).

Messages

Total messages: 32 (11 generated)
jfernandez
This is a WIP patch, but I appreciate any early feedback about my preliminary approach. ...
1 year, 4 months ago (2015-10-14 21:12:07 UTC) #3
cbiesinger
https://codereview.chromium.org/1407633003/diff/60001/third_party/WebKit/Source/core/layout/LayoutGrid.cpp File third_party/WebKit/Source/core/layout/LayoutGrid.cpp (right): https://codereview.chromium.org/1407633003/diff/60001/third_party/WebKit/Source/core/layout/LayoutGrid.cpp#newcode145 third_party/WebKit/Source/core/layout/LayoutGrid.cpp:145: class BaselineGroup { For this class and BaselineContext, can ...
1 year, 3 months ago (2015-10-26 22:07:17 UTC) #6
jfernandez
https://codereview.chromium.org/1407633003/diff/60001/third_party/WebKit/Source/core/layout/LayoutGrid.cpp File third_party/WebKit/Source/core/layout/LayoutGrid.cpp (right): https://codereview.chromium.org/1407633003/diff/60001/third_party/WebKit/Source/core/layout/LayoutGrid.cpp#newcode145 third_party/WebKit/Source/core/layout/LayoutGrid.cpp:145: class BaselineGroup { On 2015/10/26 22:07:16, cbiesinger wrote: > ...
1 year, 3 months ago (2015-10-27 09:47:56 UTC) #7
cbiesinger
https://codereview.chromium.org/1407633003/diff/60001/third_party/WebKit/Source/core/layout/LayoutGrid.cpp File third_party/WebKit/Source/core/layout/LayoutGrid.cpp (right): https://codereview.chromium.org/1407633003/diff/60001/third_party/WebKit/Source/core/layout/LayoutGrid.cpp#newcode166 third_party/WebKit/Source/core/layout/LayoutGrid.cpp:166: || (oppositeBlockDirection(child->styleRef().writingMode(), groupWritingMode) && preference != groupPreference); On 2015/10/27 ...
1 year, 3 months ago (2015-10-27 21:52:30 UTC) #8
jfernandez
I'd like @cbiesinger to take special look at how this change affects to flexbox (see ...
3 months, 1 week ago (2016-11-14 21:46:59 UTC) #11
kojii
https://codereview.chromium.org/1407633003/diff/100001/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-baseline-vertical.html File third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-baseline-vertical.html (right): https://codereview.chromium.org/1407633003/diff/100001/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-baseline-vertical.html#newcode16 third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-baseline-vertical.html:16: -webkit-writing-mode: vertical-rl; nit: better to use unprefixed versions? WebKit ...
3 months ago (2016-11-15 04:21:16 UTC) #12
jfernandez
https://codereview.chromium.org/1407633003/diff/100001/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-baseline-vertical.html File third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-baseline-vertical.html (right): https://codereview.chromium.org/1407633003/diff/100001/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-baseline-vertical.html#newcode16 third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-baseline-vertical.html:16: -webkit-writing-mode: vertical-rl; On 2016/11/15 04:21:15, kojii wrote: > nit: ...
3 months ago (2016-11-16 11:51:24 UTC) #16
kojii
https://codereview.chromium.org/1407633003/diff/100001/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp File third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp (right): https://codereview.chromium.org/1407633003/diff/100001/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp#newcode2507 third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp:2507: firstRootBox()->baselineType()))) On 2016/11/16 at 11:51:24, jfernandez wrote: > On ...
3 months ago (2016-11-16 17:18:07 UTC) #17
jfernandez
https://codereview.chromium.org/1407633003/diff/100001/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp File third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp (right): https://codereview.chromium.org/1407633003/diff/100001/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp#newcode2507 third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp:2507: firstRootBox()->baselineType()))) On 2016/11/16 17:18:06, kojii wrote: > On 2016/11/16 ...
3 months ago (2016-11-16 18:50:07 UTC) #18
kojii
https://codereview.chromium.org/1407633003/diff/160001/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp File third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp (right): https://codereview.chromium.org/1407633003/diff/160001/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp#newcode2494 third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp:2494: return !styleRef().isHorizontalWritingMode(); On 2016/11/16 at 18:50:07, jfernandez wrote: > ...
3 months ago (2016-11-18 04:14:54 UTC) #19
svillar
This is an initial review. I'd need to understand much better the concepts of baseline ...
2 months, 3 weeks ago (2016-11-25 14:44:49 UTC) #20
jfernandez
Patch ready for review. I have re-implemented almost everything, so I'd recommend doing a full ...
1 month, 1 week ago (2017-01-11 23:10:42 UTC) #21
svillar
The code is very nicely organized now. I have several comments though. https://codereview.chromium.org/1407633003/diff/220001/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp File third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp ...
1 month ago (2017-01-19 09:41:25 UTC) #22
jfernandez
https://codereview.chromium.org/1407633003/diff/220001/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp File third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp (right): https://codereview.chromium.org/1407633003/diff/220001/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp#newcode2536 third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp:2536: : firstLineBox()->logicalTop()) + On 2017/01/19 09:41:25, svillar wrote: > ...
1 month ago (2017-01-19 16:31:49 UTC) #23
jfernandez
Applied the suggested changes.
1 month ago (2017-01-21 00:29:06 UTC) #24
svillar
https://codereview.chromium.org/1407633003/diff/260001/third_party/WebKit/Source/core/layout/LayoutGrid.cpp File third_party/WebKit/Source/core/layout/LayoutGrid.cpp (right): https://codereview.chromium.org/1407633003/diff/260001/third_party/WebKit/Source/core/layout/LayoutGrid.cpp#newcode652 third_party/WebKit/Source/core/layout/LayoutGrid.cpp:652: updateLogicalWidth(); It does not seem correct to do this ...
3 weeks, 6 days ago (2017-01-23 10:41:58 UTC) #26
jfernandez
New patch with the approach discussed today. https://codereview.chromium.org/1407633003/diff/260001/third_party/WebKit/Source/core/layout/LayoutGrid.cpp File third_party/WebKit/Source/core/layout/LayoutGrid.cpp (right): https://codereview.chromium.org/1407633003/diff/260001/third_party/WebKit/Source/core/layout/LayoutGrid.cpp#newcode652 third_party/WebKit/Source/core/layout/LayoutGrid.cpp:652: updateLogicalWidth(); On ...
2 weeks, 3 days ago (2017-02-02 15:49:22 UTC) #28
svillar
We are pretty close... https://codereview.chromium.org/1407633003/diff/320001/third_party/WebKit/Source/core/layout/LayoutGrid.cpp File third_party/WebKit/Source/core/layout/LayoutGrid.cpp (right): https://codereview.chromium.org/1407633003/diff/320001/third_party/WebKit/Source/core/layout/LayoutGrid.cpp#newcode600 third_party/WebKit/Source/core/layout/LayoutGrid.cpp:600: Can't we just early return ...
1 week, 3 days ago (2017-02-09 13:10:10 UTC) #29
jfernandez
I'll provide a new patch with some of the changes suggested in the last review, ...
1 week, 3 days ago (2017-02-09 14:16:03 UTC) #30
svillar
I'm looking forward to have this in the tree. https://codereview.chromium.org/1407633003/diff/320001/third_party/WebKit/Source/core/layout/LayoutGrid.cpp File third_party/WebKit/Source/core/layout/LayoutGrid.cpp (right): https://codereview.chromium.org/1407633003/diff/320001/third_party/WebKit/Source/core/layout/LayoutGrid.cpp#newcode723 third_party/WebKit/Source/core/layout/LayoutGrid.cpp:723: ...
6 days, 12 hours ago (2017-02-13 15:18:46 UTC) #31
jfernandez
6 days, 4 hours ago (2017-02-13 23:32:38 UTC) #32
PTAL

https://codereview.chromium.org/1407633003/diff/320001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/LayoutGrid.cpp (right):

https://codereview.chromium.org/1407633003/diff/320001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutGrid.cpp:723:
computeBaselineAlignmentContext(sizingData);
On 2017/02/13 15:18:46, svillar wrote:
> On 2017/02/09 14:16:03, jfernandez wrote:
> > On 2017/02/09 13:10:09, svillar wrote:
> > > Not sure why you insert the computation in the middle of the track sizing
> > > algorithm. Note that the first track might be a flexible sized track which
> is
> > > not yet resolved.
> > > 
> > > I believe we should move it out from here (also related the track sizing
> > > algorithm is not outside of LayoutGrid).
> > 
> > We must do it here to so that when repeating the track sizing algo, for
> columns
> > and rows, content-sized tracks take the baseline offset into account. 
> 
> Sorry about this. Yes it's propertly placed. I was cheated by the comment I
> think you really need to simplify it and to correct it because it's wrong.
First
> this is not done after the step 2, this is done after the whole algorithm was

I meant step 2 as described here:

https://drafts.csswg.org/css-grid/#algo-overview

> run. Secondly you mention stuff about content sized tracks not resolved.
That's
> wrong, they're already resolved.

What I mean is that items's size as percentage are not resolved
yet since we haven't set yet their override size. We do that
later, as part of the layoutGridItems logic. However, for 
content-sized tracks, we actually set the items' override size and
perform the layout. 

So, in case of fixed tracks we can't, at this point, compute 
the baseline offsets accurately.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f8e48bd