[css-grid] Implementation of Baseline Self-Alignment

third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 2504 matching lines @@
   for (const RootInlineBox* box = firstRootBox(); box;
        box = box->nextRootBox()) {
     count++;
     if (box == stopRootInlineBox)
       break;
   }
   return count;
 }
 
 int LayoutBlockFlow::firstLineBoxBaseline() const {
-  if (isWritingModeRoot() && !isRubyRun())
+  if (isWritingModeRoot() && !isRubyRun() && !isGridItem())
     return -1;
   if (!childrenInline())
     return LayoutBlock::firstLineBoxBaseline();
   if (firstLineBox()) {
     const SimpleFontData* fontData = style(true)->font().primaryFont();
     DCHECK(fontData);
     if (!fontData)
       return -1;
-    return (firstLineBox()->logicalTop() +
+    return ((styleRef().isFlippedLinesWritingMode()
+                 ? logicalHeight() - firstLineBox()->logicalBottom()
+                 : firstLineBox()->logicalTop()) +

[svillar, 2017/01/19 09:41:25]

I don't fully understand this change but it does require non-grid tests for
sure.

[jfernandez, 2017/01/19 16:31:48]

I can add more tests, indeed, since this line fixes as well the flexbox bug
#663355 and probably some other cases as well. I can define some layout tests in
fast/writing-mode folder touching different layout models. 

However, bear in mind that I'm using inline-block as reference test, so in a way
these lines are indeed being tested. 

             fontData->getFontMetrics().ascent(firstRootBox()->baselineType()))
         .toInt();
   }
   return -1;
 }
 
 int LayoutBlockFlow::inlineBlockBaseline(
     LineDirectionMode lineDirection) const {
   // CSS2.1 states that the baseline of an 'inline-block' is:
   // the baseline of the last line box in the normal flow, unless it has
@@ skipping 2053 matching lines @@
   return LayoutBlock::invalidatePaintIfNeeded(paintInvalidationState);
 }
 
 void LayoutBlockFlow::invalidateDisplayItemClients(
     PaintInvalidationReason invalidationReason) const {
   BlockFlowPaintInvalidator(*this).invalidateDisplayItemClients(
       invalidationReason);
 }
 
 }  // namespace blink